[CodeQuality] Skip append from params on InlineArrayReturnAssignRector (#7273)

* [CodeQuality] Skip append from params on InlineArrayReturnAssignRector

* Fix

Author: samsonasik

rules-tests/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector/Fixture/skip_append_from_params.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector\Fixture;
+
+final class SkipAppendFromParams
+{
+    public function run($person)
+    {
+        $person['name'] = 'Timmy';
+        $person['id'] = 1;
+
+        return $person;
+    }
+}

rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php

@@ -10,6 +10,7 @@
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Expr\Variable;
+use PhpParser\Node\FunctionLike;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Return_;
@@ -92,6 +93,14 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($node instanceof FunctionLike) {
+            foreach ($node->getParams() as $param) {
+                if ($this->isName($param->var, $returnedVariableName)) {
+                    return null;
+                }
+            }
+        }
+
         $emptyArrayAssign = $this->resolveDefaultEmptyArrayAssign($stmts, $returnedVariableName);
         if (! $this->areAssignExclusiveToDimFetchVariable($stmts, $emptyArrayAssign, $returnedVariableName)) {
             return null;