Merge pull request #92 from gaearon/fix-stale-getState

Fix stale state inside action creators on hot reload

Author: gaearon

src/createDispatcher.js

@@ -13,10 +13,10 @@ export default function createDispatcher(store, middlewares = []) {
       return state;
     }
 
-    if (typeof middlewares === 'function') {
-      middlewares = middlewares(getState);
-    }
+    const finalMiddlewares = typeof middlewares === 'function' ?
+      middlewares(getState) :
+      middlewares;
 
-    return composeMiddleware(...middlewares, dispatch);
+    return composeMiddleware(...finalMiddlewares, dispatch);
   };
 }

test/createRedux.spec.js

@@ -53,4 +53,20 @@ describe('createRedux', () => {
     ]);
     expect(changeListenerSpy.calls.length).toBe(1);
   });
+
+  it('should use existing state when replacing the dispatcher', () => {
+    redux.dispatch(addTodo('Hello'));
+
+    let nextRedux = createRedux({ todoStore });
+    redux.replaceDispatcher(nextRedux.getDispatcher());
+
+    let state;
+    let action = (_, getState) => {
+      state = getState().todoStore;
+    };
+
+    redux.dispatch(action);
+
+    expect(state).toEqual(redux.getState().todoStore);
+  });
 });