Skip to content

Commit f2abf19

Browse files
authored
Merge pull request #3507 from vkarak/enhancement/valid_sysenv-logging
Improve logging of test case generation
2 parents f51058c + 75f2f54 commit f2abf19

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

reframe/frontend/executors/__init__.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
SkipTestError,
2929
StatisticsError,
3030
TaskExit)
31+
from reframe.core.logging import getlogger
3132
from reframe.core.schedulers.local import LocalJobScheduler
3233
from reframe.frontend.printer import PrettyPrinter
3334

@@ -174,11 +175,17 @@ def generate_testcases(checks, prepare=False):
174175

175176
cases = []
176177
for c in checks:
178+
getlogger().debug(
179+
f'Resolving systems/environments for {c.display_name!r} with:'
180+
)
181+
getlogger().debug(f' > valid_systems: {c.valid_systems}')
182+
getlogger().debug(f' > valid_prog_environs: {c.valid_prog_environs}')
177183
valid_comb = runtime.valid_sysenv_comb(c.valid_systems,
178184
c.valid_prog_environs)
179185
for part, environs in valid_comb.items():
180186
for env in environs:
181187
case = TestCase(c, part, env)
188+
getlogger().debug(f' Generated test case: {case}')
182189
if prepare:
183190
case.prepare()
184191

@@ -470,7 +477,7 @@ def finalize(self):
470477
with open(jsonfile, 'w') as fp:
471478
jsonext.dump(self.check, fp, indent=2)
472479
except OSError as e:
473-
logging.getlogger().warning(
480+
getlogger().warning(
474481
f'could not dump test case {self.testcase}: {e}'
475482
)
476483

@@ -480,7 +487,7 @@ def finalize(self):
480487
self._perflogger.log_performance(logging.INFO, self,
481488
multiline=self._perflog_compat)
482489
except LoggingError as e:
483-
logging.getlogger().warning(
490+
getlogger().warning(
484491
f'could not log performance data for {self.testcase}: {e}'
485492
)
486493

@@ -505,7 +512,7 @@ def _wait_job(job):
505512
self._perflogger.log_performance(logging.INFO, self,
506513
multiline=self._perflog_compat)
507514
except LoggingError as e:
508-
logging.getlogger().warning(
515+
getlogger().warning(
509516
f'could not log performance data for {self.testcase}: {e}'
510517
)
511518

@@ -519,7 +526,7 @@ def abort(self, cause=None):
519526
if self.failed or self._aborted:
520527
return
521528

522-
logging.getlogger().debug2(f'Aborting test case: {self.testcase!r}')
529+
getlogger().debug2(f'Aborting test case: {self.testcase!r}')
523530
exc = AbortTaskError()
524531
exc.__cause__ = cause
525532
self._aborted = True

0 commit comments

Comments
 (0)