Skip to content

OAuth2Session: Provide a default token_updater that just replaces self.token #411

@smarie

Description

@smarie

To make the auto-refresh procedure work with our oauth2 server I discovered that I had to create the token_updater function myself, and that it was this very simple one-liner:

oauth_session = OAuth2Session(client=my_oauth_client,  # the client knows the scope already
                              auto_refresh_url=refresh_token_url,
                              auto_refresh_kwargs={'client_id': client_id,
                                                   'target': client_id,
                                                   'api_type': refresh_api_type},
                              # Until PR is accepted the scope need to be repeated
                              scope=scopes  # https://github.com/requests/requests-oauthlib/pull/409
                              )

# HERE: could we get rid of this code by default ?
# the update procedure that will be called on successful token refresh
def token_updater(new_token):
    oauth_session.token = new_token
oauth_session.token_updater = token_updater

Am I right to think that the last three lines of code could be done automatically by default ?

If so I can propose a PR

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions