Add share link button to time panel context menu (#11186)

### Related

- Part of #10817
- Based on #11183

### What

Adds share buttons to timeline context menus (left click) as described
in #10817

 - [x] Look into adding keybind and keybind in ui (leave for future PR)

Author: IsseW

.typos.toml

@@ -34,7 +34,7 @@ analogue = "analog"
 analyse = "analyze"
 appetiser = "appetizer"
 arbour = "arbor"
-ardour = "arbor"
+ardor = "arbor"
 armour = "armor"
 artefact = "artifact"
 authorise = "authorize"
@@ -175,4 +175,6 @@ extend-ignore-re = [
   "cros-codecs",
 
   "muh_scalars", # Weird name introduced in `crates/viewer/re_view_time_series/tests/basic.rs` introduced in https://github.com/rerun-io/rerun/pull/10713
+
+  "isse", # Name
 ]

Cargo.lock

@@ -9071,7 +9071,6 @@ dependencies = [
  "thiserror 1.0.69",
  "tokio",
  "url",
- "vec1",
  "wasm-bindgen",
  "wasm-bindgen-futures",
  "web-sys",
@@ -9110,10 +9109,12 @@ dependencies = [
  "re_byte_size",
  "re_chunk",
  "re_chunk_store",
+ "re_data_source",
  "re_entity_db",
  "re_format",
  "re_global_context",
  "re_log",
+ "re_log_encoding",
  "re_log_types",
  "re_query",
  "re_renderer",
@@ -9131,6 +9132,7 @@ dependencies = [
  "static_assertions",
  "thiserror 1.0.69",
  "tokio",
+ "vec1",
  "wasm-bindgen-futures",
  "web-sys",
  "wgpu",

crates/viewer/re_global_context/src/command_sender.rs

@@ -96,12 +96,10 @@ pub enum SystemCommand {
         fragment: re_uri::Fragment,
     },
 
-    /// Copies an url to the clipboard to the given a display mode, selection range, and url fragment.
-    CopyUrlWithContext {
-        display_mode: crate::DisplayMode,
-        time_range: Option<re_uri::TimeSelection>,
-        fragment: re_uri::Fragment,
-    },
+    /// Copies the given url to the clipboard.
+    ///
+    /// On web this adds the viewer url as the base url.
+    CopyViewerUrl(String),
 
     /// Set the item selection.
     SetSelection(crate::ItemCollection),

crates/viewer/re_redap_browser/src/lib.rs

@@ -16,14 +16,7 @@ pub use self::{
 use re_uri::Scheme;
 use std::sync::LazyLock;
 
-/// Origin used to show the examples ui in the redap browser.
-///
-/// Not actually a valid origin.
-pub static EXAMPLES_ORIGIN: LazyLock<re_uri::Origin> = LazyLock::new(|| re_uri::Origin {
-    scheme: Scheme::RerunHttps,
-    host: url::Host::Domain(String::from("_examples.rerun.io")),
-    port: 443,
-});
+pub use re_viewer_context::open_url::EXAMPLES_ORIGIN;
 
 /// Origin used to show the local ui in the redap browser.
 ///

crates/viewer/re_test_context/src/lib.rs

@@ -588,8 +588,8 @@ impl TestContext {
                     // This adds new system commands, which will be handled later in the loop.
                     self.go_to_dataset_data(store_id, fragment);
                 }
-                SystemCommand::CopyUrlWithContext { .. } => {
-                    // Ignore copying to clipboard here.
+                SystemCommand::CopyViewerUrl(_) => {
+                    // Ignore this trying to copy to the clipboard.
                 }
                 SystemCommand::AppendToStore(store_id, chunks) => {
                     let store_hub = self.store_hub.get_mut();

crates/viewer/re_time_panel/src/time_control_ui.rs

@@ -25,7 +25,7 @@ impl TimeControlUi {
             ui.visuals_mut().widgets.hovered.expansion = 0.0;
             ui.visuals_mut().widgets.open.expansion = 0.0;
 
-            egui::ComboBox::from_id_salt("timeline")
+            let response = egui::ComboBox::from_id_salt("timeline")
                 .selected_text(time_control.timeline().name().as_str())
                 .show_ui(ui, |ui| {
                     for timeline_stats in times_per_timeline.timelines_with_stats() {
@@ -75,6 +75,28 @@ You can also define your own timelines, e.g. for sensor time or camera frame num
                             true,
                         );
                     });
+                });
+            // Sort of an inline of the `egui::Response::context_menu` function.
+            // This is required to assign an id to the context menu, which would
+            // otherwise conflict with the popup of this `ComboBox`'s popup menu.
+            egui::Popup::menu(&response)
+                .id(egui::Id::new("timeline select context menu"))
+                .open_memory(if response.secondary_clicked() {
+                    Some(egui::SetOpenCommand::Bool(true))
+                } else if response.clicked() {
+                    // Explicitly close the menu if the widget was clicked
+                    // Without this, the context menu would stay open if the user clicks the widget
+                    Some(egui::SetOpenCommand::Bool(false))
+                } else {
+                    None
+                })
+                .at_pointer_fixed()
+                .show(|ui| {
+                    if ui.button("Copy timeline name").clicked() {
+                        let timeline = format!("{}", time_control.timeline().name());
+                        re_log::info!("Copied timeline: {}", timeline);
+                        ui.ctx().copy_text(timeline);
+                    }
                 })
         });
     }

crates/viewer/re_time_panel/src/time_panel.rs

@@ -18,6 +18,7 @@ use re_types::reflection::ComponentDescriptorExt as _;
 use re_types_core::ComponentDescriptor;
 use re_ui::{ContextExt as _, DesignTokens, Help, UiExt as _, filter_widget, icons, list_item};
 use re_ui::{IconText, filter_widget::format_matching_text};
+use re_viewer_context::open_url::ViewerOpenUrl;
 use re_viewer_context::{
     CollapseScope, HoverHighlight, Item, ItemCollection, ItemContext, RecordingConfig,
     SystemCommand, SystemCommandSender as _, TimeControl, TimeView, UiLayout, ViewerContext,
@@ -567,6 +568,7 @@ impl TimePanel {
             &self.time_ranges_ui,
             time_ctrl,
             ui,
+            ctx,
             Some(&time_area_response),
             &time_area_painter,
             &timeline_rect,
@@ -1388,6 +1390,7 @@ impl TimePanel {
                     &time_ranges_ui,
                     time_ctrl,
                     ui,
+                    ctx,
                     None,
                     &painter,
                     &time_range_rect,
@@ -1404,7 +1407,9 @@ impl TimePanel {
         ui: &mut egui::Ui,
         time_ctrl: &mut TimeControl,
     ) {
-        if let Some(time_int) = time_ctrl.time_int() {
+        if let Some(time_int) = time_ctrl.time_int()
+            && let Some(time) = time_ctrl.time()
+        {
             let time_type = time_ctrl.time_type();
 
             let mut time_str = self
@@ -1426,11 +1431,11 @@ impl TimePanel {
                 }
                 self.time_edit_string = None;
             }
-            response
-                .on_hover_text(format!("Timestamp: {}", time_int.as_i64()))
-                .context_menu(|ui| {
-                    copy_time_properties_context_menu(ui, time_ctrl, None);
-                });
+            let response = response.on_hover_text(format!("Timestamp: {}", time_int.as_i64()));
+
+            response.context_menu(|ui| {
+                copy_time_properties_context_menu(ui, time);
+            });
         }
     }
 }
@@ -1776,29 +1781,79 @@ fn interact_with_streams_rect(
 }
 
 /// Context menu that shows up when interacting with the streams rect.
-fn copy_time_properties_context_menu(
+fn copy_timeline_properties_context_menu(
     ui: &mut egui::Ui,
+    ctx: &ViewerContext<'_>,
     time_ctrl: &TimeControl,
-    hovered_time: Option<TimeReal>,
+    hovered_time: TimeReal,
 ) {
-    if let Some(time) = hovered_time {
-        if ui.button("Copy hovered timestamp").clicked() {
-            let time = format!("{}", time.floor().as_i64());
-            re_log::info!("Copied hovered timestamp: {}", time);
-            ui.ctx().copy_text(time);
-        }
-    } else if let Some(time) = time_ctrl.time_int()
-        && ui.button("Copy current timestamp").clicked()
+    let mut url = ViewerOpenUrl::from_context(ctx);
+    if let Some(selected_time_range) = time_ctrl.active_loop_selection()
+        && selected_time_range.contains(hovered_time)
     {
-        let time = format!("{}", time.as_i64());
-        re_log::info!("Copied current timestamp: {}", time);
+        let has_time_range = url.as_mut().is_ok_and(|url| url.fragment_mut().is_some());
+        let copy_command = url.and_then(|url| url.copy_url_command());
+        if ui
+            .add_enabled(
+                copy_command.is_ok() && has_time_range,
+                egui::Button::new("Copy link to trimmed range"),
+            )
+            .on_disabled_hover_text(if copy_command.is_err() {
+                "Can't share links to the current recording"
+            } else {
+                "The current recording doesn't support time range links"
+            })
+            .clicked()
+            && let Ok(copy_command) = copy_command
+        {
+            ctx.command_sender().send_system(copy_command);
+        }
+    } else {
+        let has_fragment = url.as_mut().is_ok_and(|url| {
+            if let Some(fragment) = url.fragment_mut() {
+                fragment.when = Some((
+                    *time_ctrl.timeline().name(),
+                    re_log_types::TimeCell {
+                        typ: time_ctrl.time_type(),
+                        value: hovered_time.floor().into(),
+                    },
+                ));
+                true
+            } else {
+                false
+            }
+        });
+        let copy_command = url.and_then(|url| url.copy_url_command());
+
+        if ui
+            .add_enabled(
+                copy_command.is_ok() && has_fragment,
+                egui::Button::new("Copy link to timestamp"),
+            )
+            .on_disabled_hover_text(if copy_command.is_err() {
+                "Can't share links to the current recording"
+            } else {
+                "The current recording doesn't support time stamp links"
+            })
+            .clicked()
+            && let Ok(copy_command) = copy_command
+        {
+            ctx.command_sender().send_system(copy_command);
+        }
+    }
+
+    if ui.button("Copy timestamp").clicked() {
+        let time = format!("{}", hovered_time.floor().as_i64());
+        re_log::info!("Copied hovered timestamp: {}", time);
         ui.ctx().copy_text(time);
     }
+}
 
-    if ui.button("Copy current timeline name").clicked() {
-        let timeline = format!("{}", time_ctrl.timeline().name());
-        re_log::info!("Copied current timeline: {}", timeline);
-        ui.ctx().copy_text(timeline);
+fn copy_time_properties_context_menu(ui: &mut egui::Ui, time: TimeReal) {
+    if ui.button("Copy timestamp").clicked() {
+        let time = format!("{}", time.floor().as_i64());
+        re_log::info!("Copied hovered timestamp: {}", time);
+        ui.ctx().copy_text(time);
     }
 }
 
@@ -1807,6 +1862,7 @@ fn time_marker_ui(
     time_ranges_ui: &TimeRangesUi,
     time_ctrl: &mut TimeControl,
     ui: &egui::Ui,
+    ctx: &ViewerContext<'_>,
     time_area_response: Option<&egui::Response>,
     time_area_painter: &egui::Painter,
     timeline_rect: &Rect,
@@ -1869,19 +1925,38 @@ fn time_marker_ui(
         let is_pointer_in_timeline_rect =
             ui.ui_contains_pointer() && timeline_rect.contains(pointer_pos);
 
-        // Show preview?
-        if !is_hovering_time_cursor
+        let hovered_ctx_id = egui::Id::new("hovered timestamp context");
+
+        let on_timeline = !is_hovering_time_cursor
             && !time_area_double_clicked
             && is_pointer_in_time_area_rect
             && !is_anything_being_dragged
-            && !is_hovering_the_loop_selection
+            && !is_hovering_the_loop_selection;
+
+        if on_timeline {
+            ui.ctx().set_cursor_icon(timeline_cursor_icon);
+        }
+
+        // Show a preview bar at this position, if we have right-clicked
+        // on the time panel we want to still draw the line at the
+        // original position.
+        let hovered_x_pos = if let Some(hovered_time) =
+            ui.ctx().memory(|mem| mem.data.get_temp(hovered_ctx_id))
+            && let Some(x) = time_ranges_ui.x_from_time_f32(hovered_time)
         {
+            Some(x)
+        } else if on_timeline {
+            Some(pointer_pos.x)
+        } else {
+            None
+        };
+
+        if let Some(x) = hovered_x_pos {
             time_area_painter.vline(
-                pointer_pos.x,
+                x,
                 timeline_rect.top()..=ui.max_rect().bottom(),
                 ui.visuals().widgets.noninteractive.fg_stroke,
             );
-            ui.ctx().set_cursor_icon(timeline_cursor_icon); // preview!
         }
 
         // Click to move time here:
@@ -1920,8 +1995,25 @@ fn time_marker_ui(
             }
         }
 
-        time_area_response
-            .context_menu(|ui| copy_time_properties_context_menu(ui, time_ctrl, hovered_time));
+        if let Some(hovered_time) = ui
+            .ctx()
+            .memory(|mem| mem.data.get_temp(hovered_ctx_id))
+            .or(hovered_time)
+        {
+            if egui::Popup::context_menu(&time_area_response)
+                .width(300.0)
+                .show(|ui| {
+                    copy_timeline_properties_context_menu(ui, ctx, time_ctrl, hovered_time);
+                })
+                .is_some()
+            {
+                ui.ctx()
+                    .memory_mut(|mem| mem.data.insert_temp(hovered_ctx_id, hovered_time));
+            } else {
+                ui.ctx()
+                    .memory_mut(|mem| mem.data.remove::<TimeReal>(hovered_ctx_id));
+            }
+        }
     }
 }
 

crates/viewer/re_viewer/Cargo.toml

@@ -140,7 +140,6 @@ serde-wasm-bindgen.workspace = true
 tap.workspace = true
 thiserror.workspace = true
 url.workspace = true
-vec1.workspace = true
 web-time.workspace = true
 wgpu.workspace = true