Only show share timestamp when it's supported

Author: IsseW

crates/viewer/re_time_panel/src/time_panel.rs

@@ -1784,21 +1784,24 @@ fn copy_timeline_properties_context_menu(
     time_ctrl: &TimeControl,
     hovered_time: TimeReal,
 ) {
-    // TODO: Add shortcuts for these
-    if let Some(selected_time_range) = time_ctrl.active_loop_selection()
-        && selected_time_range.contains(hovered_time)
-    {
-        if ui.button("Copy link to trimmed range").clicked() {
-            ctx.command_sender()
-                .send_system(UrlContext::from_context(ctx).into_copy_cmd());
+    let url_context = UrlContext::from_context(ctx);
+    if let Some(url_features) = url_context.features(ctx.storage_context.hub) {
+        if let Some(selected_time_range) = time_ctrl.active_loop_selection()
+            && selected_time_range.contains(hovered_time)
+            && url_features.time_range
+        {
+            if ui.button("Copy link to trimmed range").clicked() {
+                ctx.command_sender()
+                    .send_system(url_context.without_timestamp().into_copy_cmd());
+            }
+        } else if url_features.fragment && ui.button("Copy link to timestamp").clicked() {
+            ctx.command_sender().send_system(
+                UrlContext::from_context(ctx)
+                    .without_time_range()
+                    .with_timestamp(time_ctrl.timeline(), hovered_time.into())
+                    .into_copy_cmd(),
+            );
         }
-    } else if ui.button("Copy link to timestamp").clicked() {
-        ctx.command_sender().send_system(
-            UrlContext::from_context(ctx)
-                .without_time_range()
-                .with_timestamp(time_ctrl.timeline(), hovered_time.into())
-                .into_copy_cmd(),
-        );
     }
 
     if ui.button("Copy timestamp").clicked() {

crates/viewer/re_viewer_context/src/url_context.rs

@@ -1,4 +1,5 @@
 use re_global_context::{DisplayMode, SystemCommand};
+use re_smart_channel::SmartChannelSource;
 
 use crate::ViewerContext;
 
@@ -12,7 +13,60 @@ pub struct UrlContext {
     pub fragment: re_uri::Fragment,
 }
 
+#[derive(Default, Clone, Copy)]
+pub struct UrlFeatures {
+    pub time_range: bool,
+    pub fragment: bool,
+}
+
 impl UrlContext {
+    /// Information about what this url can do, can be used to hide UI for
+    /// sharing when we know it won't work.
+    ///
+    /// This should be kept up to date with what `ViewerOpenUrl::new` does
+    // TODO(isse): I don't really like how this has to be kept up to date manually with
+    // `ViewerOpenUrl`, would be nice to consolidate.
+    pub fn features(&self, store_hub: &crate::StoreHub) -> Option<UrlFeatures> {
+        match &self.display_mode {
+            DisplayMode::Settings | DisplayMode::LocalTable(_) | DisplayMode::ChunkStoreBrowser => {
+                None
+            }
+
+            DisplayMode::LocalRecordings => {
+                let active_recording = store_hub.active_recording()?;
+                let data_source = active_recording.data_source.as_ref()?;
+                match data_source {
+                    SmartChannelSource::RrdHttpStream { .. }
+                    | SmartChannelSource::RrdWebEventListener
+                    | SmartChannelSource::MessageProxy(_) => Some(UrlFeatures::default()),
+
+                    SmartChannelSource::RedapGrpcStream { .. } => Some(UrlFeatures {
+                        time_range: true,
+                        fragment: true,
+                    }),
+
+                    SmartChannelSource::File(_) => {
+                        #[cfg(not(target_arch = "wasm32"))]
+                        {
+                            Some(UrlFeatures::default())
+                        }
+                        #[cfg(target_arch = "wasm32")]
+                        {
+                            None
+                        }
+                    }
+
+                    SmartChannelSource::JsChannel { .. }
+                    | SmartChannelSource::Sdk
+                    | SmartChannelSource::Stdin => None,
+                }
+            }
+            DisplayMode::RedapServer(_) | DisplayMode::RedapEntry(_) => {
+                Some(UrlFeatures::default())
+            }
+        }
+    }
+
     /// Create a url for a certain display mode.
     ///
     /// Not all display modes lead to valid URLs.