Skip to content

Commit fc7f16d

Browse files
committed
add back removed check for if we're paused before updating time fragment
1 parent 414607e commit fc7f16d

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

crates/viewer/re_viewer/src/app.rs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,8 +559,15 @@ impl App {
559559

560560
let Ok(url) = crate::open_url::ViewerOpenUrl::new(
561561
store_hub,
562-
UrlContext::from_context_expanded(display_mode, time_ctrl.as_deref(), selection)
563-
.without_time_range(),
562+
UrlContext::from_context_expanded(
563+
display_mode,
564+
time_ctrl
565+
.as_deref()
566+
// Only update `when` fragment when paused.
567+
.filter(|time_ctrl| matches!(time_ctrl.play_state(), PlayState::Paused)),
568+
selection,
569+
)
570+
.without_time_range(),
564571
)
565572
// History entries expect the url parameter, not the full url, therefore don't pass a base url.
566573
.and_then(|url| url.sharable_url(None)) else {

crates/viewer/re_viewer/src/open_url.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ impl ViewerOpenUrl {
233233
}
234234
#[cfg(target_arch = "wasm32")]
235235
{
236+
_ = path_buf;
236237
Err(anyhow::anyhow!(
237238
"Can't share links to local files on the web."
238239
))

0 commit comments

Comments
 (0)