Adds failing test example for #223 502 bad gateway (#224)

GabLeRoux · rokob · commit 87ba05b8da74 · 2018-02-16T15:41:18.000-08:00
* Adds failing test example for #223 * special case 502 errors
diff --git a/rollbar/__init__.py b/rollbar/__init__.py
@@ -1390,6 +1390,9 @@ def _parse_response(path, access_token, params, resp, endpoint=None):
     if resp.status_code == 429:
         log.warning("Rollbar: over rate limit, data was dropped. Payload was: %r", params)
         return
+    elif resp.status_code == 502:
+        log.exception('Rollbar api returned a 502')
+        return
     elif resp.status_code == 413:
         uuid = None
         host = None
diff --git a/rollbar/test/test_rollbar.py b/rollbar/test/test_rollbar.py
@@ -436,6 +436,24 @@ def test_trigger_failsafe(self, post, _send_failsafe):
             rollbar.report_exc_info()
             self.assertEqual(_send_failsafe.call_count, 2)
 
+    @mock.patch('rollbar._send_failsafe')
+    @mock.patch('rollbar.lib.transport.post',
+                side_effect=lambda *args, **kw: MockRawResponse('<html>\r\n' \
+                                                             '<head><title>502 Bad Gateway</title></head>\r\n' \
+                                                             '<body bgcolor="white">\r\n' \
+                                                             '<center><h1>502 Bad Gateway</h1></center>\r\n' \
+                                                             '<hr><center>nginx</center>\r\n' \
+                                                             '</body>\r\n' \
+                                                             '</html>\r\n', 502))
+    def test_502_failsafe(self, post, _send_failsafe):
+        rollbar.report_message('derp')
+        # self.assertEqual(_send_failsafe.call_count, 1)
+
+        try:
+            raise Exception('trigger_failsafe')
+        except:
+            rollbar._post_api('/api/1/item', {'derp'})
+
     @mock.patch('rollbar.send_payload')
     def test_send_failsafe(self, send_payload):
         test_uuid = str(uuid.uuid4())
@@ -1217,6 +1235,19 @@ def content(self):
     def json(self):
         return self.json_data
 
+
+class MockRawResponse:
+    def __init__(self, data, status_code):
+        self.data = data
+        self.status_code = status_code
+
+    @property
+    def content(self):
+        return self.data
+
+    def json(self):
+        return self.data
+
 class MockLambdaContext(object):
     def __init__(self, x):
         self.function_name = 1
