fix: Return None if template doesn't exist (#160)

Author: shriyaedu

examples/templates.py

@@ -0,0 +1,24 @@
+# /// script
+# requires-python = ">=3.10"
+# dependencies = ["galileo"]
+# ///
+
+from galileo import Message, MessageRole
+from galileo.prompts import create_prompt_template, get_prompt_template
+
+# Get existing template
+prompt_template = get_prompt_template(name="good-prompt", project="My first project")
+
+# Create template if it doesn't exist
+if prompt_template is None:
+    prompt_template = create_prompt_template(
+        name="good-prompt",
+        project="My first project",
+        messages=[
+            Message(role=MessageRole.SYSTEM, content="you are a helpful assistant"),
+            Message(role=MessageRole.USER, content="why is sky blue?"),
+        ],
+    )
+
+# Retrieve the template we just created
+retrieved_template = get_prompt_template(project="My First Project", name="science-assistant")

src/galileo/prompts.py

@@ -122,7 +122,8 @@ def get_prompt_template(project: str, name: str) -> Optional[PromptTemplate]:
         if prompt_template.name == name:
             _logger.info(f"Get template {prompt_template}")
             return prompt_template
-    raise ValueError(f"Prompt {name} does not exist")
+    _logger.warning(f"Template {name} not found in project {project}")
+    return None
 
 
 def list_prompt_templates(project: str) -> list[PromptTemplate]:

tests/test_prompts.py

@@ -120,3 +120,36 @@ def test_list_prompts(list_prompt_templates_mock: Mock, get_projects_projects_ge
 
     list_prompt_templates_mock.sync.assert_called_once()
     get_projects_projects_get_mock.sync_detailed.assert_called_once()
+
+
+@patch("galileo.projects.get_projects_projects_get")
+@patch("galileo.prompts.get_project_templates_projects_project_id_templates_get")
+def test_get_prompt_template_found(list_prompt_templates_mock: Mock, get_projects_projects_get_mock: Mock):
+    """Test get_prompt_template when template exists."""
+    list_prompt_templates_mock.sync.return_value = [prompt_template()]
+    get_projects_projects_get_mock.sync_detailed.return_value = projects_response()
+
+    from galileo.prompts import get_prompt_template
+
+    template = get_prompt_template(name="andrii-good-prompt", project="andrii-new-project")
+
+    assert template is not None
+    assert template.name == "andrii-good-prompt"
+    list_prompt_templates_mock.sync.assert_called_once()
+    get_projects_projects_get_mock.sync_detailed.assert_called_once()
+
+
+@patch("galileo.projects.get_projects_projects_get")
+@patch("galileo.prompts.get_project_templates_projects_project_id_templates_get")
+def test_get_prompt_template_not_found(list_prompt_templates_mock: Mock, get_projects_projects_get_mock: Mock):
+    """Test get_prompt_template when template doesn't exist."""
+    list_prompt_templates_mock.sync.return_value = [prompt_template()]  # Return a different template
+    get_projects_projects_get_mock.sync_detailed.return_value = projects_response()
+
+    from galileo.prompts import get_prompt_template
+
+    template = get_prompt_template(name="nonexistent-template", project="andrii-new-project")
+
+    assert template is None
+    list_prompt_templates_mock.sync.assert_called_once()
+    get_projects_projects_get_mock.sync_detailed.assert_called_once()