-
Notifications
You must be signed in to change notification settings - Fork 20
Open
Labels
bugSomething isn't workingSomething isn't workingcontributor experienceRelated to making contributions easierRelated to making contributions easierhelp wantedExtra attention is neededExtra attention is neededquestionFurther information is requestedFurther information is requested
Description
In the two CERT-C ports of guidelines relating to Shifts over integer types, the table conversion from the original Markdown to Sphinx / RST didn't work well.
The PRs have since been fixed by hand. Regardless, here are the two pairs of issues and PRs that I'm talking about:
- [Coding Guideline]: Subset Guideline for CERT C, INT34-C: Do not shift an expression by a negative number of bits or by greater than or equal to the number of bits that exist in the operand #156
- [Coding Guideline]: Defect Guideline for CERT C, INT34-C: Do not shift an expression by a negative number of bits or by greater than or equal to the number of bits that exist in the operand #174
And here's an illustration of how the table looked in the original text:
| **Compilation Mode** | **`0 <= M < N`** | **`M < 0`** | **`N <= M`** |
|:--------------------:|:----------------:|:---------------------:|:-------------------:|
| Debug | Shifts normally | Panics | Panics |
| Release | Shifts normally | Shifts by `M mod N` | Shifts by `M mod N` |
CC @x0rw lemme know if there's something I can do to start improving the table conversion (maybe we can use another conversion library?)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcontributor experienceRelated to making contributions easierRelated to making contributions easierhelp wantedExtra attention is neededExtra attention is neededquestionFurther information is requestedFurther information is requested