Skip to content

Commit 871f660

Browse files
authored
v0.3.3
Hotfix for #44 * fix customization issue * update version to v0.3.3 in package.json, readme, * add details to changelog
1 parent 0aedc5f commit 871f660

File tree

4 files changed

+21
-9
lines changed

4 files changed

+21
-9
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## [0.3.3]
2+
3+
- Fixed issue where customizations would only apply if there was an existing entry for "workbench.colorCustomizations" in settings.
4+
15
## [0.3.2]
26

37
- Fixed elements not showing full names in Palette view.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
Customize your color theme for VS Code.
1010

11-
[![Version](https://img.shields.io/badge/version-0.3.2-red)]()
11+
[![Version](https://img.shields.io/badge/version-0.3.3-red)]()
1212
[![License](https://img.shields.io/badge/license-MIT-blue.svg)]()
1313

1414
[![LoveIt;ShipIt](https://gitlab.com/ryanraposo/LoveItShipIt/-/raw/master/sticker/loveitshipit.svg)](http://github.com/ryanraposo/LoveItShipIt)
@@ -59,7 +59,7 @@ The recommended method for installing CodeUI is via the Extension Marketplace, a
5959
Alternatively, you can download the VSIX from [releases](https://github.com/ryanraposo/codeui/releases) and install using the terminal with command:
6060

6161
```
62-
code --install-extension codeui-0.3.2.vsix
62+
code --install-extension codeui-0.3.3.vsix
6363
```
6464

6565
*Note: it may be necessary to reload vscode if installing via the terminal.*

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"license": "SEE LICENSE IN LICENSE.md",
66
"description": "Customize your color theme for VS Code.",
77
"icon": "resources/marketplace/codeui-128.png",
8-
"version": "0.3.2",
8+
"version": "0.3.3",
99
"preview": true,
1010
"galleryBanner": {
1111
"color": "#18191e",

src/configuration.ts

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,21 @@ class Config {
1313
}
1414

1515
getWorkbenchColorCustomizations(scope: vscode.ConfigurationTarget) {
16-
const customizations = this.config.inspect('workbench.colorCustomizations');
17-
if (customizations) {
18-
return scope == vscode.ConfigurationTarget.Global
19-
? customizations.globalValue
20-
: customizations.workspaceValue;
16+
const customizationSettingsObj = this.config.inspect('workbench.colorCustomizations');
17+
let workbenchColorCustomizations : any = {};
18+
19+
if (customizationSettingsObj) {
20+
if (scope === vscode.ConfigurationTarget.Global) {
21+
workbenchColorCustomizations = customizationSettingsObj.globalValue;
22+
}
23+
if (scope === vscode.ConfigurationTarget.Workspace) {
24+
workbenchColorCustomizations = customizationSettingsObj.workspaceValue;
25+
}
2126
}
22-
return {};
27+
if (workbenchColorCustomizations === undefined) {
28+
return {};
29+
}
30+
return workbenchColorCustomizations;
2331
}
2432

2533
getWorkspaceRootFolder(): vscode.WorkspaceFolder | undefined {

0 commit comments

Comments
 (0)