jupyter: revert removing redundant output reps on the server

- there should be only one given that we know the client, but this
  efficiency gain fights too much with what jupyter upstream expects, so
we can't do this.

Author: williamstein

src/packages/frontend/jupyter/output-messages/mime-types/html.tsx

@@ -39,6 +39,9 @@ export default function Html({
 // **backend only** text/latex and as text/html
 // that looks good and is meant to be rendered on the frontend.
 // See https://github.com/sagemathinc/cocalc/issues/5925
+// But Latex should have higher priority than HTML, e.g.,
+// sage show(...) is much better to just render using latex!
+// SIGH.
 register("text/html", 5, Html);
 
 // Heuristics to only use plain stateless html.

src/packages/jupyter/ipynb/import-from-ipynb.ts

@@ -8,10 +8,7 @@ Importing from an ipynb object (in-memory version of .ipynb file)
 */
 
 import * as misc from "@cocalc/util/misc";
-import {
-  JUPYTER_MIMETYPES,
-  JUPYTER_MIMETYPES_SET,
-} from "@cocalc/jupyter/util/misc";
+import { JUPYTER_MIMETYPES } from "@cocalc/jupyter/util/misc";
 import { type Message } from "@cocalc/jupyter/execute/output-handler";
 import { close } from "@cocalc/util/misc";
 
@@ -257,7 +254,6 @@ export class IPynbImporter {
     if (misc.is_array(content.text)) {
       content.text = content.text.join("");
     }
-    remove_redundant_reps(content.data); // multiple output formats
     delete content.prompt_number; // redundant; in some files
   };
 
@@ -403,38 +399,3 @@ export class IPynbImporter {
     return obj;
   };
 }
-
-// mutate data removing redundant reps
-export function remove_redundant_reps(data?: object) {
-  if (data == null) {
-    return;
-  }
-  // We only keep the first representation in types, since it provides the richest
-  // representation in the client; there is no need for the others.
-  // TODO: probably we should still store all of these types somewhere (in the
-  // backend only) for the .ipynb export, but I'm not doing that right now!
-  // This means opening and closing an ipynb file may lose information, which
-  // no client currently cares about (?) -- maybe nbconvert does.
-  let keep = "";
-  for (const type of JUPYTER_MIMETYPES) {
-    if (data[type] != null) {
-      keep = type;
-      break;
-    }
-  }
-  if (!keep) {
-    return;
-  }
-  for (const type in data) {
-    // NOTE: we only remove multiple reps that are both in JUPYTER_MIMETYPES;
-    // if there is another rep that is NOT in JUPYTER_MIMETYPES, then it is
-    // not removed, e.g., application/vnd.jupyter.widget-view+json and
-    // text/plain both are types of representation of a widget.
-    if (
-      type != keep &&
-      (JUPYTER_MIMETYPES_SET as Set<string>).has(type) != null
-    ) {
-      delete data[type];
-    }
-  }
-}

src/packages/jupyter/redux/actions.ts

@@ -49,7 +49,6 @@ import {
   JUPYTER_MIMETYPES,
   isJupyterBase64MimeType,
 } from "@cocalc/jupyter/util/misc";
-import { remove_redundant_reps } from "@cocalc/jupyter/ipynb/import-from-ipynb";
 import { isSha1, sha1 } from "@cocalc/util/misc";
 import { shouldUseIframe } from "@cocalc/jupyter/util/iframe";
 
@@ -2106,8 +2105,6 @@ export class JupyterActions extends Actions<JupyterStoreState> {
       return;
     }
 
-    remove_redundant_reps(content.data);
-
     // Here we compute sha1 and start saving the blob to the blob store
     // over the network.  There is no guarantee that will work and this
     // won't just be lost. It's unlikely but could happen.  This is

src/packages/jupyter/util/misc.ts

@@ -24,9 +24,9 @@ import { cmp } from "@cocalc/util/misc";
 export const JUPYTER_MIMETYPES = [
   "application/javascript",
   "application/json",
-  "text/latex",
   "text/html",
   "text/markdown",
+  "text/latex",
   "image/svg+xml",
   "image/png",
   "image/jpeg",