SAK-51588 Conversations sakai-topic test race condition (#13819)

Author: ern

webcomponents/tool/src/main/frontend/packages/sakai-conversations/src/SakaiTopic.js

@@ -113,14 +113,14 @@ export class SakaiTopic extends reactionsAndUpvotingMixin(SakaiElement) {
 
     // If there are no new posts to mark as viewed, return early
     if (newPostIds.length === 0) {
-      return;
+      return Promise.resolve();
     }
 
     // Add these posts to our tracked set before making the request
     newPostIds.forEach(id => this._observedPosts.add(id));
 
     const url = this.topic.links.find(l => l.rel === "markpostsviewed").href;
-    fetch(url, {
+    return fetch(url, {
       method: "POST",
       headers: { "Content-Type": "application/json" },
       body: JSON.stringify(newPostIds),
@@ -149,7 +149,10 @@ export class SakaiTopic extends reactionsAndUpvotingMixin(SakaiElement) {
         throw new Error(`Network error while marking posts as viewed at url ${url}`);
       }
     })
-    .catch (error => console.error(error));
+    .catch (error => {
+      console.error(error);
+      throw error;
+    });
   }
 
   _savePostAsDraft() { this._postToTopic(true); }

webcomponents/tool/src/main/frontend/packages/sakai-conversations/test/topic.test.js

@@ -566,10 +566,13 @@ describe("sakai-topic tests", () => {
     const originalObserver = el.observer;
     el.observer = { observe: observeSpy, unobserve: unobserveSpy };
 
+    // Set up event listener for "posts-viewed" before calling the method
+    const eventPromise = oneEvent(el, "posts-viewed");
+    
     // Call the method directly with the post IDs
-    el._markPostsViewed(["post1"]);
+    await el._markPostsViewed(["post1"]);
 
-    const { detail } = await oneEvent(el, "posts-viewed");
+    const { detail } = await eventPromise;
 
     expect(detail.postIds).to.include("post1");
     expect(detail.topicId).to.equal(topic.id);