Skip to content

Remove mentions of jars from the Book #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvaled opened this issue Oct 27, 2024 · 0 comments · May be fixed by #775
Open

Remove mentions of jars from the Book #609

mvaled opened this issue Oct 27, 2024 · 0 comments · May be fixed by #775

Comments

@mvaled
Copy link

mvaled commented Oct 27, 2024

The Salsa Book's tutorial includes (empty) mentions to #[salsa::jar] which was seemingly removed (see commit 65118a0).

There a many mentions of jars in the book which makes no sense when trying to read through the examples, e.g #[salsa::db(Jar1, ... JarN)] however this is never used in any code.

Similarly the Book mentions HasJars and HasJarsDyn; which are nowhere to be found in the code anymore (commit c84bd1b)

This is kind of confusing because the Tutorial starts with there jars without any salsa inside ;)

@detrumi detrumi linked a pull request Mar 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant