Skip to content

Panic with predictable value if there is no initial fn in cycle #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nikomatsakis opened this issue Feb 20, 2025 · 1 comment · May be fixed by #856
Open

Panic with predictable value if there is no initial fn in cycle #704

nikomatsakis opened this issue Feb 20, 2025 · 1 comment · May be fixed by #856

Comments

@nikomatsakis
Copy link
Member

When there is a cycle with no initial value we currently panic with a string, but we should have a more recognizable value.

Originally posted by @nikomatsakis in #603 (comment)
@carljm carljm mentioned this issue Apr 16, 2025
Merged
@Veykril
Copy link
Member

Veykril commented Apr 17, 2025

Note that if we do this, we should not be panicking but unwinding with a such a value as to not print the now rather confusing Box<dyn Any> backtrace.

@Veykril Veykril linked a pull request May 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unwind with specific type when encountering an unexpected cycle Veykril/salsa
2 participants
@nikomatsakis @Veykril