Merge pull request #34 from scribd/griffinf/APT-10128-update-seeking-playback-progress

griffinfscribd · web-flow · commit 67d37df6ae9a · 2024-06-06T10:58:50.000-07:00
[APT-10128] Fixed the order of dispatched actions during seek related…
diff --git a/Armadillo/src/main/java/com/scribd/armadillo/playback/PlaybackEngine.kt b/Armadillo/src/main/java/com/scribd/armadillo/playback/PlaybackEngine.kt
@@ -243,7 +243,7 @@ internal class ExoplayerPlaybackEngine(private var audioPlayable: AudioPlayable)
     }
 
     private fun seekToExo(position: Milliseconds) {
-        exoPlayer.seekTo(exoPlayer.currentMediaItemIndex, position.longValue)
         stateModifier.dispatch(PlaybackProgressAction(position, exoPlayer.playerDuration()))
+        exoPlayer.seekTo(exoPlayer.currentMediaItemIndex, position.longValue)
     }
 }
diff --git a/RELEASE.md b/RELEASE.md
@@ -1,5 +1,8 @@
 # Project Armadillo Release Notes
 
+## 1.3.2
+- Added a fix for order of dispatched actions during seek related events
+
 ## 1.3.1
 - Adds support for offline DRM for downloaded MPEG-DASH audio
 
diff --git a/gradle.properties b/gradle.properties
@@ -12,7 +12,7 @@ org.gradle.jvmargs=-Xmx1536m
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 # org.gradle.parallel=true
 PACKAGE_NAME=com.scribd.armadillo
-LIBRARY_VERSION=1.3.1
+LIBRARY_VERSION=1.3.2
 EXOPLAYER_VERSION=2.17.1
 RXJAVA_VERSION=2.2.4
 RXANDROID_VERSION=2.0.1

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ internal class ExoplayerPlaybackEngine(private var audioPlayable: AudioPlayable)`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`private fun seekToExo(position: Milliseconds) {`
`246`		`- exoPlayer.seekTo(exoPlayer.currentMediaItemIndex, position.longValue)`
`247`	`246`	`stateModifier.dispatch(PlaybackProgressAction(position, exoPlayer.playerDuration()))`
	`247`	`+ exoPlayer.seekTo(exoPlayer.currentMediaItemIndex, position.longValue)`
`248`	`248`	`}`
`249`	`249`	`}`