Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Commit 1027ca5

Browse files
committed
fix: change default rcc and uic output file names to *_rc and *_ui
We should add an e2e test for such case in the future. Fix #289
1 parent 980351c commit 1027ca5

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@
364364
},
365365
"default": [
366366
"-o",
367-
"${resourceDirname}${pathSeparator}rc_${resourceBasenameNoExtension}.py"
367+
"${resourceDirname}${pathSeparator}${resourceBasenameNoExtension}_rc.py"
368368
],
369369
"markdownDescription": "The options passed to Qt `rcc` executable. See [here](https://github.com/seanwu1105/vscode-qt-for-python#predefined-variables) for a detailed list of predefined variables.",
370370
"scope": "resource"
@@ -393,7 +393,7 @@
393393
},
394394
"default": [
395395
"-o",
396-
"${resourceDirname}${pathSeparator}ui_${resourceBasenameNoExtension}.py"
396+
"${resourceDirname}${pathSeparator}${resourceBasenameNoExtension}_ui.py"
397397
],
398398
"markdownDescription": "The options passed to Qt `uic` executable. See [here](https://github.com/seanwu1105/vscode-qt-for-python#predefined-variables) for a detailed list of predefined variables.",
399399
"scope": "resource"

python/.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
rc_*.py
2-
ui_*.py
1+
*_rc.py
2+
*_ui.py

src/test/suite/rcc/compile-resource.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import { URI } from 'vscode-uri'
55
import { EXTENSION_NAMESPACE } from '../../../constants'
66
import {
77
E2E_TIMEOUT,
8+
TEST_ASSETS_PATH,
89
forceDeleteFile,
910
setupE2EEnvironment,
10-
TEST_ASSETS_PATH,
1111
waitFor,
1212
} from '../test-utils'
1313

@@ -55,7 +55,7 @@ suite('compile-resource/e2e', () => {
5555
path.resolve(
5656
TEST_ASSETS_PATH,
5757
'qrc',
58-
`rc_${sampleFilenameNoExt}.py`,
58+
`${sampleFilenameNoExt}_rc.py`,
5959
),
6060
),
6161
)
@@ -69,6 +69,6 @@ suite('compile-resource/e2e', () => {
6969

7070
async function removeGeneratedFile(sampleFilenameNoExt: string) {
7171
await forceDeleteFile(
72-
path.resolve(TEST_ASSETS_PATH, 'qrc', `rc_${sampleFilenameNoExt}.py`),
72+
path.resolve(TEST_ASSETS_PATH, 'qrc', `${sampleFilenameNoExt}_rc.py`),
7373
)
7474
}

src/test/suite/rcc/rcc-live-execution.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ suite('rcc-live-execution/e2e', () => {
6464
path.resolve(
6565
TEST_ASSETS_PATH,
6666
'qrc',
67-
`rc_${sampleQrcFilenameNoExt}.py`,
67+
`${sampleQrcFilenameNoExt}_rc.py`,
6868
),
6969
),
7070
)
@@ -110,7 +110,7 @@ suite('rcc-live-execution/e2e', () => {
110110
path.resolve(
111111
TEST_ASSETS_PATH,
112112
'qrc',
113-
`rc_${sampleQrcFilenameNoExt}.py`,
113+
`${sampleQrcFilenameNoExt}_rc.py`,
114114
),
115115
),
116116
)
@@ -122,6 +122,6 @@ suite('rcc-live-execution/e2e', () => {
122122

123123
async function removeGeneratedFile(sampleFilenameNoExt: string) {
124124
await forceDeleteFile(
125-
path.resolve(TEST_ASSETS_PATH, 'qrc', `rc_${sampleFilenameNoExt}.py`),
125+
path.resolve(TEST_ASSETS_PATH, 'qrc', `${sampleFilenameNoExt}_rc.py`),
126126
)
127127
}

src/test/suite/uic/compile-ui.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import { URI } from 'vscode-uri'
55
import { EXTENSION_NAMESPACE } from '../../../constants'
66
import {
77
E2E_TIMEOUT,
8+
TEST_ASSETS_PATH,
89
forceDeleteFile,
910
setupE2EEnvironment,
10-
TEST_ASSETS_PATH,
1111
waitFor,
1212
} from '../test-utils'
1313

@@ -55,7 +55,7 @@ suite('compile-ui/e2e', () => {
5555
path.resolve(
5656
TEST_ASSETS_PATH,
5757
'ui',
58-
`ui_${sampleFilenameNoExt}.py`,
58+
`${sampleFilenameNoExt}_ui.py`,
5959
),
6060
),
6161
)
@@ -69,6 +69,6 @@ suite('compile-ui/e2e', () => {
6969

7070
async function removeGeneratedFile(sampleFilenameNoExt: string) {
7171
return forceDeleteFile(
72-
path.resolve(TEST_ASSETS_PATH, 'ui', `ui_${sampleFilenameNoExt}.py`),
72+
path.resolve(TEST_ASSETS_PATH, 'ui', `${sampleFilenameNoExt}_ui.py`),
7373
)
7474
}

src/test/suite/uic/uic-live-execution.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ suite('uic-live-execution/e2e', () => {
5555
await waitFor(async () => {
5656
const readResult = await workspace.fs.readFile(
5757
URI.file(
58-
path.resolve(TEST_ASSETS_PATH, 'ui', `ui_${sampleFilenameNoExt}.py`),
58+
path.resolve(TEST_ASSETS_PATH, 'ui', `${sampleFilenameNoExt}_ui.py`),
5959
),
6060
)
6161

@@ -66,6 +66,6 @@ suite('uic-live-execution/e2e', () => {
6666

6767
async function removeGeneratedFile(sampleFilenameNoExt: string) {
6868
return forceDeleteFile(
69-
path.resolve(TEST_ASSETS_PATH, 'ui', `ui_${sampleFilenameNoExt}.py`),
69+
path.resolve(TEST_ASSETS_PATH, 'ui', `${sampleFilenameNoExt}_ui.py`),
7070
)
7171
}

0 commit comments

Comments
 (0)