Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit 6669746

Browse files
authored
Merge pull request #112 from secureCodeBox/allow-to-customize-s3-secret-attributes
Allow to Change Attribute Names on the S3 Secret
2 parents c0e5c89 + 01ed8c3 commit 6669746

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

operator/templates/manager/manager.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@ spec:
6464
valueFrom:
6565
secretKeyRef:
6666
name: {{ .Values.s3.keySecret }}
67-
key: accesskey
67+
key: {{ .Values.s3.secretAttributeNames.accesskey }}
6868
- name: S3_SECRET_KEY
6969
valueFrom:
7070
secretKeyRef:
7171
name: {{ .Values.s3.keySecret }}
72-
key: secretkey
72+
key: {{ .Values.s3.secretAttributeNames.secretkey }}
7373
{{- end }}
7474
- name: LURCHER_IMAGE
7575
value: "{{ .Values.lurcher.image.repository }}:{{ .Values.lurcher.image.tag | default .Chart.Version }}"

operator/values.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,15 @@ s3:
3232
bucket: "my-bucket"
3333
# Implicit 443. You probably only need to change this when the system uses a non default port
3434
port: null
35-
# Name to a k8s secret with 'accesskey' and 'secretkey' as attributes in the same namespace as this release
35+
# Name to a k8s secret in the same namespace as this release with credentials to the s3 bucket
36+
# By default this assumes to have 'accesskey' and 'secretkey' as attributes
3637
# Example creation via kubectl:
3738
# kubectl create secret generic my-secret --from-literal=accessKey="******" --from-literal=secretKey="******"
3839
keySecret: my-secret
40+
# Names to the attributes in the s3 secret
41+
secretAttributeNames:
42+
accesskey: accesskey
43+
secretkey: secretkey
3944

4045
#
4146
# Config for the operator ressource limits

0 commit comments

Comments
 (0)