From b098609ccb94988842530520eb224bd0212d67f2 Mon Sep 17 00:00:00 2001 From: Peter Dannemann Date: Wed, 25 Jun 2025 11:07:51 -0400 Subject: [PATCH 1/6] fix: lower max msg byte in docker compose to allow us to test against kafka 4.0 --- .circleci/config.yml | 103 +++++++++++++++++++++---------------------- 1 file changed, 50 insertions(+), 53 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index a32a0d322..09fc79e54 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -30,7 +30,7 @@ jobs: KAFKA_ADVERTISED_PORT: '9092' KAFKA_ZOOKEEPER_CONNECT: localhost:2181 KAFKA_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_MESSAGE_MAX_BYTES: '200000000' + KAFKA_MESSAGE_MAX_BYTES: '20000000' KAFKA_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' @@ -102,7 +102,7 @@ jobs: KAFKA_CFG_ADVERTISED_PORT: '9092' KAFKA_CFG_ZOOKEEPER_CONNECT: localhost:2181 KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '200000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' KAFKA_CFG_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_CFG_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' @@ -178,57 +178,54 @@ jobs: entrypoint: *entrypoint steps: *steps - # NOTE: this fails quite often due to Java heap errors from Kafka. - # Once we figure out how to fix that, we can re-enable this. - # https://github.com/segmentio/kafka-go/issues/1360#issuecomment-2858935900 - # kafka-400: - # working_directory: *working_directory - # environment: - # KAFKA_VERSION: "4.0.0" + kafka-400: + working_directory: *working_directory + environment: + KAFKA_VERSION: "4.0.0" - # # Need to skip nettest to avoid these kinds of errors: - # # --- FAIL: TestConn/nettest (17.56s) - # # --- FAIL: TestConn/nettest/PingPong (7.40s) - # # conntest.go:112: unexpected Read error: [7] Request Timed Out: the request exceeded the user-specified time limit in the request - # # conntest.go:118: mismatching value: got 77, want 78 - # # conntest.go:118: mismatching value: got 78, want 79 - # # ... - # # - # # TODO: Figure out why these are happening and fix them (they don't appear to be new). - # KAFKA_SKIP_NETTEST: "1" - # docker: - # - image: circleci/golang - # - image: bitnami/kafka:4.0.0 - # ports: - # - 9092:9092 - # - 9093:9093 - # environment: - # KAFKA_CFG_NODE_ID: 1 - # KAFKA_CFG_BROKER_ID: 1 - # KAFKA_CFG_PROCESS_ROLES: broker,controller - # KAFKA_CFG_ADVERTISED_HOST_NAME: 'localhost' - # KAFKA_CFG_CONTROLLER_LISTENER_NAMES: CONTROLLER - # KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP: CONTROLLER:PLAINTEXT,PLAIN:PLAINTEXT,SASL:SASL_PLAINTEXT - # KAFKA_CFG_LISTENERS: CONTROLLER://:9094,PLAIN://:9092,SASL://:9093 - # KAFKA_CFG_ADVERTISED_LISTENERS: PLAIN://localhost:9092,SASL://localhost:9093 - # KAFKA_CFG_INTER_BROKER_LISTENER_NAME: PLAIN - # KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' - # KAFKA_CFG_CONTROLLER_QUORUM_VOTERS: 1@localhost:9094 - # ALLOW_PLAINTEXT_LISTENER: yes - # KAFKA_CFG_ALLOW_EVERYONE_IF_NO_ACL_FOUND: 'true' - # KAFKA_OPTS: "-Djava.security.auth.login.config=/opt/bitnami/kafka/config/kafka_jaas.conf" - # KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' - # KAFKA_CFG_DELETE_TOPIC_ENABLE: 'true' - # KAFKA_CFG_MESSAGE_MAX_BYTES: '200000000' - # KAFKA_CFG_AUTHORIZER_CLASS_NAME: 'org.apache.kafka.metadata.authorizer.StandardAuthorizer' - # KAFKA_CFG_SUPER_USERS: User:adminscram256;User:adminscram512;User:adminplain - # KAFKA_CLIENT_USERS: adminscram256,adminscram512,adminplain - # KAFKA_CLIENT_PASSWORDS: admin-secret-256,admin-secret-512,admin-secret - # KAFKA_CLIENT_SASL_MECHANISMS: SCRAM-SHA-256,SCRAM-SHA-512,PLAIN - # KAFKA_INTER_BROKER_USER: adminscram512 - # KAFKA_INTER_BROKER_PASSWORD: admin-secret-512 - # KAFKA_CFG_SASL_MECHANISM_INTER_BROKER_PROTOCOL: SCRAM-SHA-512 - # steps: *steps + # Need to skip nettest to avoid these kinds of errors: + # --- FAIL: TestConn/nettest (17.56s) + # --- FAIL: TestConn/nettest/PingPong (7.40s) + # conntest.go:112: unexpected Read error: [7] Request Timed Out: the request exceeded the user-specified time limit in the request + # conntest.go:118: mismatching value: got 77, want 78 + # conntest.go:118: mismatching value: got 78, want 79 + # ... + # + # TODO: Figure out why these are happening and fix them (they don't appear to be new). + KAFKA_SKIP_NETTEST: "1" + docker: + - image: circleci/golang + - image: bitnami/kafka:4.0.0 + ports: + - 9092:9092 + - 9093:9093 + environment: + KAFKA_CFG_NODE_ID: 1 + KAFKA_CFG_BROKER_ID: 1 + KAFKA_CFG_PROCESS_ROLES: broker,controller + KAFKA_CFG_ADVERTISED_HOST_NAME: 'localhost' + KAFKA_CFG_CONTROLLER_LISTENER_NAMES: CONTROLLER + KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP: CONTROLLER:PLAINTEXT,PLAIN:PLAINTEXT,SASL:SASL_PLAINTEXT + KAFKA_CFG_LISTENERS: CONTROLLER://:9094,PLAIN://:9092,SASL://:9093 + KAFKA_CFG_ADVERTISED_LISTENERS: PLAIN://localhost:9092,SASL://localhost:9093 + KAFKA_CFG_INTER_BROKER_LISTENER_NAME: PLAIN + KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' + KAFKA_CFG_CONTROLLER_QUORUM_VOTERS: 1@localhost:9094 + ALLOW_PLAINTEXT_LISTENER: yes + KAFKA_CFG_ALLOW_EVERYONE_IF_NO_ACL_FOUND: 'true' + KAFKA_OPTS: "-Djava.security.auth.login.config=/opt/bitnami/kafka/config/kafka_jaas.conf" + KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' + KAFKA_CFG_DELETE_TOPIC_ENABLE: 'true' + KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' + KAFKA_CFG_AUTHORIZER_CLASS_NAME: 'org.apache.kafka.metadata.authorizer.StandardAuthorizer' + KAFKA_CFG_SUPER_USERS: User:adminscram256;User:adminscram512;User:adminplain + KAFKA_CLIENT_USERS: adminscram256,adminscram512,adminplain + KAFKA_CLIENT_PASSWORDS: admin-secret-256,admin-secret-512,admin-secret + KAFKA_CLIENT_SASL_MECHANISMS: SCRAM-SHA-256,SCRAM-SHA-512,PLAIN + KAFKA_INTER_BROKER_USER: adminscram512 + KAFKA_INTER_BROKER_PASSWORD: admin-secret-512 + KAFKA_CFG_SASL_MECHANISM_INTER_BROKER_PROTOCOL: SCRAM-SHA-512 + steps: *steps workflows: version: 2 @@ -239,4 +236,4 @@ workflows: - kafka-270 - kafka-281 - kafka-370 - #- kafka-400 + - kafka-400 From dc99591d4fb43a4439f44bdbbc5591a1dfc5b4f7 Mon Sep 17 00:00:00 2001 From: Peter Dannemann Date: Wed, 25 Jun 2025 11:20:04 -0400 Subject: [PATCH 2/6] increase timeout for elect leaders test --- electleaders_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/electleaders_test.go b/electleaders_test.go index 3dbaa4704..1ecb4298e 100644 --- a/electleaders_test.go +++ b/electleaders_test.go @@ -3,6 +3,7 @@ package kafka import ( "context" "testing" + "time" ktesting "github.com/segmentio/kafka-go/testing" ) @@ -14,6 +15,8 @@ func TestClientElectLeaders(t *testing.T) { ctx := context.Background() client, shutdown := newLocalClient() + // on Kraft mode leader elections take longer + client.Timeout = 10 * time.Second defer shutdown() topic := makeTopic() From 7acab1c8955015ae7232d93a1b43310f7b5ec673 Mon Sep 17 00:00:00 2001 From: Peter Dannemann Date: Wed, 25 Jun 2025 11:31:09 -0400 Subject: [PATCH 3/6] properly fix request timeout --- electleaders_test.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/electleaders_test.go b/electleaders_test.go index 1ecb4298e..8933bb4c1 100644 --- a/electleaders_test.go +++ b/electleaders_test.go @@ -15,8 +15,6 @@ func TestClientElectLeaders(t *testing.T) { ctx := context.Background() client, shutdown := newLocalClient() - // on Kraft mode leader elections take longer - client.Timeout = 10 * time.Second defer shutdown() topic := makeTopic() @@ -29,6 +27,7 @@ func TestClientElectLeaders(t *testing.T) { &ElectLeadersRequest{ Topic: topic, Partitions: []int{0, 1}, + Timeout: 5 * time.Second, }, ) From 36b8591020bfab899582eca769af39a42e7ea45f Mon Sep 17 00:00:00 2001 From: Peter Dannemann Date: Wed, 25 Jun 2025 11:32:07 -0400 Subject: [PATCH 4/6] drop max msg bytes everywhere --- docker-compose.yml | 2 +- docker_compose_versions/docker-compose-010.yml | 2 +- docker_compose_versions/docker-compose-270.yml | 2 +- docker_compose_versions/docker-compose-370.yml | 2 +- docker_compose_versions/docker-compose-400.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index dffb0e448..8e511270c 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -25,7 +25,7 @@ services: KAFKA_CFG_ADVERTISED_PORT: '9092' KAFKA_CFG_ZOOKEEPER_CONNECT: zookeeper:2181 KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '200000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' KAFKA_CFG_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_CFG_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' diff --git a/docker_compose_versions/docker-compose-010.yml b/docker_compose_versions/docker-compose-010.yml index 35df0b5c6..c7e705c98 100644 --- a/docker_compose_versions/docker-compose-010.yml +++ b/docker_compose_versions/docker-compose-010.yml @@ -25,7 +25,7 @@ services: KAFKA_ADVERTISED_PORT: '9092' KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181 KAFKA_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_MESSAGE_MAX_BYTES: '200000000' + KAFKA_MESSAGE_MAX_BYTES: '20000000' KAFKA_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' diff --git a/docker_compose_versions/docker-compose-270.yml b/docker_compose_versions/docker-compose-270.yml index de48cb290..8af3319e5 100644 --- a/docker_compose_versions/docker-compose-270.yml +++ b/docker_compose_versions/docker-compose-270.yml @@ -25,7 +25,7 @@ services: KAFKA_CFG_ADVERTISED_PORT: '9092' KAFKA_CFG_ZOOKEEPER_CONNECT: zookeeper:2181 KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '200000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' KAFKA_CFG_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_CFG_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' diff --git a/docker_compose_versions/docker-compose-370.yml b/docker_compose_versions/docker-compose-370.yml index dffb0e448..8e511270c 100644 --- a/docker_compose_versions/docker-compose-370.yml +++ b/docker_compose_versions/docker-compose-370.yml @@ -25,7 +25,7 @@ services: KAFKA_CFG_ADVERTISED_PORT: '9092' KAFKA_CFG_ZOOKEEPER_CONNECT: zookeeper:2181 KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '200000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' KAFKA_CFG_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_CFG_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' diff --git a/docker_compose_versions/docker-compose-400.yml b/docker_compose_versions/docker-compose-400.yml index b563d5e39..647e32b4f 100644 --- a/docker_compose_versions/docker-compose-400.yml +++ b/docker_compose_versions/docker-compose-400.yml @@ -25,7 +25,7 @@ services: KAFKA_OPTS: "-Djava.security.auth.login.config=/opt/bitnami/kafka/config/kafka_jaas.conf" KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' KAFKA_CFG_DELETE_TOPIC_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '200000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' KAFKA_CFG_AUTHORIZER_CLASS_NAME: 'org.apache.kafka.metadata.authorizer.StandardAuthorizer' KAFKA_CFG_SUPER_USERS: User:adminscram256;User:adminscram512;User:adminplain KAFKA_CLIENT_USERS: adminscram256,adminscram512,adminplain From eddbed3970554aca14fdb74fe2ffb71c9e2aca01 Mon Sep 17 00:00:00 2001 From: Peter Dannemann Date: Wed, 25 Jun 2025 11:50:06 -0400 Subject: [PATCH 5/6] further drop max msg bytes --- .circleci/config.yml | 2 +- docker-compose.yml | 2 +- docker_compose_versions/docker-compose-010.yml | 2 +- docker_compose_versions/docker-compose-270.yml | 2 +- docker_compose_versions/docker-compose-370.yml | 2 +- docker_compose_versions/docker-compose-400.yml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 09fc79e54..e2f83bdc7 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -216,7 +216,7 @@ jobs: KAFKA_OPTS: "-Djava.security.auth.login.config=/opt/bitnami/kafka/config/kafka_jaas.conf" KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' KAFKA_CFG_DELETE_TOPIC_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '2000000' KAFKA_CFG_AUTHORIZER_CLASS_NAME: 'org.apache.kafka.metadata.authorizer.StandardAuthorizer' KAFKA_CFG_SUPER_USERS: User:adminscram256;User:adminscram512;User:adminplain KAFKA_CLIENT_USERS: adminscram256,adminscram512,adminplain diff --git a/docker-compose.yml b/docker-compose.yml index 8e511270c..17d5943b8 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -25,7 +25,7 @@ services: KAFKA_CFG_ADVERTISED_PORT: '9092' KAFKA_CFG_ZOOKEEPER_CONNECT: zookeeper:2181 KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '2000000' KAFKA_CFG_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_CFG_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' diff --git a/docker_compose_versions/docker-compose-010.yml b/docker_compose_versions/docker-compose-010.yml index c7e705c98..a93279752 100644 --- a/docker_compose_versions/docker-compose-010.yml +++ b/docker_compose_versions/docker-compose-010.yml @@ -25,7 +25,7 @@ services: KAFKA_ADVERTISED_PORT: '9092' KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181 KAFKA_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_MESSAGE_MAX_BYTES: '20000000' + KAFKA_MESSAGE_MAX_BYTES: '2000000' KAFKA_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' diff --git a/docker_compose_versions/docker-compose-270.yml b/docker_compose_versions/docker-compose-270.yml index 8af3319e5..3bffffb32 100644 --- a/docker_compose_versions/docker-compose-270.yml +++ b/docker_compose_versions/docker-compose-270.yml @@ -25,7 +25,7 @@ services: KAFKA_CFG_ADVERTISED_PORT: '9092' KAFKA_CFG_ZOOKEEPER_CONNECT: zookeeper:2181 KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '2000000' KAFKA_CFG_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_CFG_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' diff --git a/docker_compose_versions/docker-compose-370.yml b/docker_compose_versions/docker-compose-370.yml index 8e511270c..17d5943b8 100644 --- a/docker_compose_versions/docker-compose-370.yml +++ b/docker_compose_versions/docker-compose-370.yml @@ -25,7 +25,7 @@ services: KAFKA_CFG_ADVERTISED_PORT: '9092' KAFKA_CFG_ZOOKEEPER_CONNECT: zookeeper:2181 KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '2000000' KAFKA_CFG_LISTENERS: 'PLAINTEXT://:9092,SASL_PLAINTEXT://:9093' KAFKA_CFG_ADVERTISED_LISTENERS: 'PLAINTEXT://localhost:9092,SASL_PLAINTEXT://localhost:9093' KAFKA_CFG_SASL_ENABLED_MECHANISMS: 'PLAIN,SCRAM-SHA-256,SCRAM-SHA-512' diff --git a/docker_compose_versions/docker-compose-400.yml b/docker_compose_versions/docker-compose-400.yml index 647e32b4f..e9499cf90 100644 --- a/docker_compose_versions/docker-compose-400.yml +++ b/docker_compose_versions/docker-compose-400.yml @@ -25,7 +25,7 @@ services: KAFKA_OPTS: "-Djava.security.auth.login.config=/opt/bitnami/kafka/config/kafka_jaas.conf" KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: 'true' KAFKA_CFG_DELETE_TOPIC_ENABLE: 'true' - KAFKA_CFG_MESSAGE_MAX_BYTES: '20000000' + KAFKA_CFG_MESSAGE_MAX_BYTES: '2000000' KAFKA_CFG_AUTHORIZER_CLASS_NAME: 'org.apache.kafka.metadata.authorizer.StandardAuthorizer' KAFKA_CFG_SUPER_USERS: User:adminscram256;User:adminscram512;User:adminplain KAFKA_CLIENT_USERS: adminscram256,adminscram512,adminplain From d4baafdf4f4d4c2d2c4c86008365cead76558ec2 Mon Sep 17 00:00:00 2001 From: Peter Dannemann Date: Wed, 25 Jun 2025 12:02:32 -0400 Subject: [PATCH 6/6] wait for user scram creds to be created before describing --- client_test.go | 2 +- describeuserscramcredentials_test.go | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/client_test.go b/client_test.go index 62153b234..f9d5cd188 100644 --- a/client_test.go +++ b/client_test.go @@ -167,7 +167,7 @@ func testConsumerGroupFetchOffsets(t *testing.T, ctx context.Context, client *Cl for i := 0; i < totalMessages; i++ { m, err := r.FetchMessage(ctx) if err != nil { - t.Fatalf("error fetching message: %s", err) + t.Fatalf("error fetching message number %d: %s", i, err) } if err := r.CommitMessages(context.Background(), m); err != nil { t.Fatal(err) diff --git a/describeuserscramcredentials_test.go b/describeuserscramcredentials_test.go index d30b47477..ffc96b546 100644 --- a/describeuserscramcredentials_test.go +++ b/describeuserscramcredentials_test.go @@ -4,6 +4,7 @@ import ( "context" "errors" "testing" + "time" ktesting "github.com/segmentio/kafka-go/testing" "github.com/stretchr/testify/assert" @@ -48,6 +49,9 @@ func TestDescribeUserScramCredentials(t *testing.T) { t.Fatalf("didn't expect an error in createResult, got %v", createRes.Results[0].Error) } + // Kraftmode is slow, wait for the user scram credentials to be created + time.Sleep(1 * time.Second) + describeCreationRes, err := client.DescribeUserScramCredentials(context.Background(), &DescribeUserScramCredentialsRequest{ Users: []UserScramCredentialsUser{ {