Merge pull request #710 from fjtirado/Fix_#708

[Fix_708] Fixing recursivity when using then loop

Author: fjtirado

impl/core/src/main/java/io/serverlessworkflow/impl/executors/AbstractTaskExecutor.java

@@ -61,7 +61,8 @@ public abstract class AbstractTaskExecutor<T extends TaskBase> implements TaskEx
   private final Optional<SchemaValidator> contextSchemaValidator;
   private final Optional<WorkflowPredicate> ifFilter;
 
-  public abstract static class AbstractTaskExecutorBuilder<T extends TaskBase>
+  public abstract static class AbstractTaskExecutorBuilder<
+          T extends TaskBase, V extends AbstractTaskExecutor<T>>
       implements TaskExecutorBuilder<T> {
     private Optional<WorkflowFilter> inputProcessor = Optional.empty();
     private Optional<WorkflowFilter> outputProcessor = Optional.empty();
@@ -77,7 +78,7 @@ public abstract static class AbstractTaskExecutorBuilder<T extends TaskBase>
     protected final Workflow workflow;
     protected final ResourceLoader resourceLoader;
 
-    private TaskExecutor<T> instance;
+    private V instance;
 
     protected AbstractTaskExecutorBuilder(
         WorkflowMutablePosition position,
@@ -145,17 +146,20 @@ private TaskExecutorBuilder<?> next(Map<String, TaskExecutorBuilder<?>> connecti
       return next;
     }
 
-    public TaskExecutor<T> build() {
+    public V build() {
       if (instance == null) {
         instance = buildInstance();
+        buildTransition(instance);
       }
       return instance;
     }
 
-    protected abstract TaskExecutor<T> buildInstance();
+    protected abstract V buildInstance();
+
+    protected abstract void buildTransition(V instance);
   }
 
-  protected AbstractTaskExecutor(AbstractTaskExecutorBuilder<T> builder) {
+  protected AbstractTaskExecutor(AbstractTaskExecutorBuilder<T, ?> builder) {
     this.task = builder.task;
     this.taskName = builder.taskName;
     this.position = builder.position;

impl/core/src/main/java/io/serverlessworkflow/impl/executors/CallTaskExecutor.java

@@ -46,7 +46,7 @@ protected CallTaskExecutorBuilder(
     }
 
     @Override
-    public TaskExecutor<T> buildInstance() {
+    public CallTaskExecutor<T> buildInstance() {
       return new CallTaskExecutor<>(this);
     }
   }

impl/core/src/main/java/io/serverlessworkflow/impl/executors/DoExecutor.java

@@ -46,7 +46,7 @@ protected DoExecutorBuilder(
     }
 
     @Override
-    public TaskExecutor<DoTask> buildInstance() {
+    public DoExecutor buildInstance() {
       return new DoExecutor(this);
     }
   }

impl/core/src/main/java/io/serverlessworkflow/impl/executors/EmitExecutor.java

@@ -61,7 +61,7 @@ protected EmitExecutorBuilder(
     }
 
     @Override
-    public TaskExecutor<EmitTask> buildInstance() {
+    public EmitExecutor buildInstance() {
       return new EmitExecutor(this);
     }
   }

impl/core/src/main/java/io/serverlessworkflow/impl/executors/ForExecutor.java

@@ -68,7 +68,7 @@ protected WorkflowValueResolver<Collection<?>> buildCollectionFilter() {
     }
 
     @Override
-    public TaskExecutor<ForTask> buildInstance() {
+    public ForExecutor buildInstance() {
       return new ForExecutor(this);
     }
   }

impl/core/src/main/java/io/serverlessworkflow/impl/executors/ForkExecutor.java

@@ -62,7 +62,7 @@ protected ForkExecutorBuilder(
     }
 
     @Override
-    public TaskExecutor<ForkTask> buildInstance() {
+    public ForkExecutor buildInstance() {
       return new ForkExecutor(this);
     }
   }

impl/core/src/main/java/io/serverlessworkflow/impl/executors/ListenExecutor.java

@@ -155,7 +155,7 @@ private EventRegistrationBuilder from(EventFilter filter) {
     }
 
     @Override
-    public TaskExecutor<ListenTask> buildInstance() {
+    public ListenExecutor buildInstance() {
       return registrations.isAnd() ? new AndListenExecutor(this) : new OrListenExecutor(this);
     }
   }

impl/core/src/main/java/io/serverlessworkflow/impl/executors/RaiseExecutor.java

@@ -114,7 +114,7 @@ private Error findError(String raiseErrorReference) {
     }
 
     @Override
-    public TaskExecutor<RaiseTask> buildInstance() {
+    public RaiseExecutor buildInstance() {
       return new RaiseExecutor(this);
     }
   }

impl/core/src/main/java/io/serverlessworkflow/impl/executors/RegularTaskExecutor.java

@@ -28,15 +28,14 @@
 
 public abstract class RegularTaskExecutor<T extends TaskBase> extends AbstractTaskExecutor<T> {
 
-  protected final TransitionInfo transition;
+  protected TransitionInfo transition;
 
   protected RegularTaskExecutor(RegularTaskExecutorBuilder<T> builder) {
     super(builder);
-    this.transition = TransitionInfo.build(builder.transition);
   }
 
   public abstract static class RegularTaskExecutorBuilder<T extends TaskBase>
-      extends AbstractTaskExecutorBuilder<T> {
+      extends AbstractTaskExecutorBuilder<T, RegularTaskExecutor<T>> {
 
     private TransitionInfoBuilder transition;
 
@@ -52,6 +51,11 @@ protected RegularTaskExecutorBuilder(
     public void connect(Map<String, TaskExecutorBuilder<?>> connections) {
       this.transition = next(task.getThen(), connections);
     }
+
+    @Override
+    protected void buildTransition(RegularTaskExecutor<T> instance) {
+      instance.transition = TransitionInfo.build(transition);
+    }
   }
 
   @Override

impl/core/src/main/java/io/serverlessworkflow/impl/executors/SetExecutor.java

@@ -54,7 +54,7 @@ protected SetExecutorBuilder(
     }
 
     @Override
-    public TaskExecutor<SetTask> buildInstance() {
+    public SetExecutor buildInstance() {
       return new SetExecutor(this);
     }
   }