Note on use of np.random.seed in genedrop functions

timothymillar · mergify[bot] · commit 2ab47b587768 · 2023-12-04T21:34:49.000Z
diff --git a/sgkit/stats/genedrop_numba_fns.py b/sgkit/stats/genedrop_numba_fns.py
@@ -5,6 +5,11 @@
 
 from .pedigree import _compress_hamilton_kerr_parameters, topological_argsort
 
+# NOTE: The use of `np.random.seed()` within numba compiled functions should not
+# affect numpy RNG. The numba implementation is thread safe (since version 0.28.0)
+# and each thread/process will produce an independent stream of random numbers.
+# See https://numba.pydata.org/numba-doc/dev/reference/numpysupported.html#random.
+
 
 @numba_guvectorize(  # type: ignore
     [

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,11 @@`
`5`	`5`
`6`	`6`	`from .pedigree import _compress_hamilton_kerr_parameters, topological_argsort`
`7`	`7`
	`8`	+# NOTE: The use of `np.random.seed()` within numba compiled functions should not
	`9`	`+# affect numpy RNG. The numba implementation is thread safe (since version 0.28.0)`
	`10`	`+# and each thread/process will produce an independent stream of random numbers.`
	`11`	`+# See https://numba.pydata.org/numba-doc/dev/reference/numpysupported.html#random.`
	`12`	`+`
`8`	`13`
`9`	`14`	`@numba_guvectorize( # type: ignore`
`10`	`15`	`[`