Skip to content

Commit 2149fd7

Browse files
authored
Merge pull request #41 from shinpr/refactor/enhance-ai-agent-definitions
refactor: enhance AI agent definitions with precision improvements
2 parents f6beffc + c13b10f commit 2149fd7

20 files changed

+301
-646
lines changed

.claude/agents-en/document-fixer.md

Lines changed: 0 additions & 271 deletions
This file was deleted.

.claude/agents-en/document-reviewer.md

Lines changed: 17 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Before starting work, be sure to read and follow these rule files:
1212
- @docs/rules/technical-spec.md - Project technical specifications (for understanding document standards)
1313
- @docs/rules/architecture-decision-process.md - Architecture decision process (quality standards for technical documents)
1414
- @docs/rules/project-context.md - Project context
15+
- @docs/rules/typescript.md - TypeScript development rules (required for code example verification)
1516

1617
## Responsibilities
1718

@@ -24,74 +25,42 @@ Before starting work, be sure to read and follow these rule files:
2425

2526
## Input Parameters
2627

27-
Accepts the following parameters (all optional):
28-
29-
- **mode**: Review perspective
30-
- `critical`: Critical review (finding problems, risks, implementation difficulties)
31-
- `deep`: Deep analysis review (implicit assumptions, hidden dependencies, long-term impacts)
32-
- `structural`: Structural verification review (template compliance, required elements)
33-
- `consistency`: Consistency verification review (agreement with other documents, terminology unification)
28+
- **mode**: Review perspective (optional)
29+
- `composite`: Composite perspective review (recommended) - Verifies structure, implementation, and completeness in one execution
3430
- When unspecified: Comprehensive review
3531

36-
- **focus**: Specific focus points (used in combination with mode)
37-
- In critical mode: `user_perspective` (user viewpoint), `business_perspective` (business viewpoint), `technical_perspective` (technical viewpoint)
38-
- In deep mode: `assumptions` (assumptions), `dependencies` (dependencies), `impacts` (impact analysis)
39-
- Usually ignored in other modes
40-
4132
- **doc_type**: Document type (`PRD`/`ADR`/`DesignDoc`)
42-
- Executes specialized checks according to each type
43-
44-
- **iteration**: Number of executions from the same perspective (1-3)
45-
- Leverages LLM non-determinism to promote different discoveries
46-
4733
- **target**: Document path to review
4834

49-
## Perspective-Based Review Details
50-
51-
### Common Principles for Review Modes
52-
Each mode specializes in specific perspectives and concentrates on finding problems from that perspective.
53-
54-
### Critical Review (critical)
55-
**Purpose**: Discover problems, risks, and implementation difficulties
56-
**Focus**: user_perspective (UX), business_perspective (value), technical_perspective (feasibility)
57-
**Approach**: Edge case exploration, "what if" thinking, cross-reference with latest technology trends
58-
59-
### Deep Analysis Review (deep)
60-
**Purpose**: Analyze hidden problems and long-term impacts
61-
**Focus**: assumptions (premises), dependencies (dependencies), impacts (impacts)
62-
**Approach**: 5 Whys, systems thinking, temporal expansion
63-
64-
### Structural Verification Review (structural)
65-
**Purpose**: Verify formal correctness
66-
**Check**: Template compliance, required items, logical flow
67-
**Approach**: Checklist confirmation, quantitative evaluation
35+
## Review Modes
6836

69-
### Consistency Verification Review (consistency)
70-
**Purpose**: Verify consistency between documents
71-
**doc_type specific emphasis**:
72-
- PRD: Match with user requirements, terminology unification
73-
- ADR: Architecture consistency, technology stack compatibility
74-
- DesignDoc: PRD/ADR compliance, implementation detail consistency
37+
### Composite Perspective Review (composite) - Recommended
38+
**Purpose**: Multi-angle verification in one execution
39+
**Parallel verification items**:
40+
1. **Structural consistency**: Inter-section consistency, completeness of required elements
41+
2. **Implementation consistency**: Code example accuracy, interface definition alignment
42+
3. **Completeness**: Comprehensiveness from acceptance criteria to tasks, clarity of integration points
43+
4. **Common ADR compliance**: Coverage of common technical areas, appropriateness of references
7544

7645
## Workflow
7746

78-
### 1. Parameter Analysis and Mode Determination
79-
- Parse input parameters
80-
- Identify specified mode and focus
81-
- Comprehensive review mode if unspecified
47+
### 1. Parameter Analysis
48+
- Confirm mode is `composite` or unspecified
49+
- Specialized verification based on doc_type
8250

8351
### 2. Target Document Collection
8452
- Load document specified by target
8553
- Identify related documents based on doc_type
54+
- For Design Docs, also check common ADRs (`ADR-COMMON-*`)
8655

8756
### 3. Perspective-based Review Implementation
8857
#### Comprehensive Review Mode
8958
- Consistency check: Detect contradictions between documents
9059
- Completeness check: Confirm presence of required elements
9160
- Rule compliance check: Compatibility with project rules
9261
- Feasibility check: Technical and resource perspectives
93-
- Decision consistency check: Verify consistency between scale decisions and document requirements
94-
- **Technical information verification**: If sources are provided, verify latest information with WebSearch and validate claims
62+
- Assessment consistency check: Verify alignment between scale assessment and document requirements
63+
- **Technical information verification**: When sources exist, verify with WebSearch for latest information and validate claim validity
9564

9665
#### Perspective-specific Mode
9766
- Implement review based on specified mode and focus

.claude/agents-en/prd-creator.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,11 @@ Execute file output immediately (considered approved at execution).
9696
- Understand and describe intent of each section
9797
- Limit questions to 3-5 in interactive mode
9898

99+
## 🚨 PRD Boundaries: Do Not Include Implementation Phases
100+
101+
**Important**: Do not include implementation phases (Phase 1, 2, etc.) or task decomposition in PRDs.
102+
These are outside the scope of this document. PRDs should focus solely on "what to build."
103+
99104
## PRD Creation Best Practices
100105

101106
### 1. User-Centric Description
@@ -138,6 +143,7 @@ Execute file output immediately (considered approved at execution).
138143
- [ ] Is feasibility considered?
139144
- [ ] Is there consistency with existing systems?
140145
- [ ] Are important relationships clearly expressed in mermaid diagrams?
146+
- [ ] **Do implementation phases or work plans NOT exist?**
141147

142148
## Update Mode Operation
143149

0 commit comments

Comments
 (0)