Skip to content

Commit 489154f

Browse files
authored
Merge pull request #2308 from wellwelwel/osx
ci: improve OSX workflows
2 parents ee43891 + aa3952d commit 489154f

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

.github/workflows/ci-osx.yml

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ env:
1414

1515
jobs:
1616
tests-osx:
17-
runs-on: macos-13
17+
runs-on: macos-latest
1818
strategy:
1919
fail-fast: false
2020
matrix:
@@ -25,7 +25,7 @@ jobs:
2525
mysql_connection_url_key: [""]
2626
# TODO - add mariadb to the matrix. currently few tests are broken due to mariadb incompatibilities
2727
include:
28-
# 20.x
28+
# 20.x
2929
- node-version: "20.x"
3030
mysql-version: "mysql:8.0.33"
3131
use-compression: 1
@@ -44,12 +44,19 @@ jobs:
4444
steps:
4545
- uses: actions/checkout@v3
4646

47-
- name: install lima
48-
run: brew install lima
47+
- name: Install Colima
48+
run: brew install colima
49+
50+
- name: Install Docker
51+
run: brew install --formula docker
52+
53+
- name: Start Docker
54+
run: colima start
55+
56+
- name: Pull MySQL
57+
if: ${{ matrix.mysql-version }}
58+
run: docker pull ${{ matrix.mysql-version }}
4959

50-
- name: Setup Docker on macOS
51-
uses: douglascamata/setup-docker-macos-action@v1-alpha
52-
5360
- name: Set up MySQL
5461
if: ${{ matrix.mysql-version }}
5562
run: docker run -d -e MYSQL_ALLOW_EMPTY_PASSWORD=1 -e MYSQL_DATABASE=${{ env.MYSQL_DATABASE }} -p ${{ env.MYSQL_PORT }}:3306 ${{ matrix.mysql-version }}
@@ -65,7 +72,7 @@ jobs:
6572
path: ~/.npm
6673
key: npm-${{ hashFiles('package-lock.json') }}
6774
restore-keys: npm-
68-
75+
6976
- name: Install npm dependencies
7077
run: npm ci
7178

@@ -78,4 +85,4 @@ jobs:
7885

7986
- name: Run tests with built-in node test runner
8087
if: ${{ matrix.use-builtin-test-runner }}
81-
run: FILTER=${{matrix.filter}} MYSQL_USE_TLS=${{ matrix.use-tls }} MYSQL_USE_COMPRESSION=${{ matrix.use-compression }} npm run test:builtin-node-runner
88+
run: FILTER=${{matrix.filter}} MYSQL_USE_TLS=${{ matrix.use-tls }} MYSQL_USE_COMPRESSION=${{ matrix.use-compression }} npm run test:builtin-node-runner

0 commit comments

Comments
 (0)