Skip to content

Commit dc2dc2b

Browse files
leoreinmannhakandilek
authored andcommitted
fix(lint): update to mypy's stricter type checking
1 parent 077dabe commit dc2dc2b

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

siemens_standard_bom/model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ def _set_supplier_if_missing(self) -> None:
596596
if not self.bom.metadata.supplier:
597597
self.bom.metadata.supplier = OrganizationalEntity(name='Siemens or its Affiliates')
598598

599-
def _set_metadata_property(self, property_name: str, value: str) -> None:
599+
def _set_metadata_property(self, property_name: str, value: Optional[str | None]) -> None:
600600
existing = next(filter(lambda p: p.name == property_name,
601601
self.bom.metadata.properties), None)
602602
if existing:
@@ -666,7 +666,7 @@ def profile(self) -> Optional[str]:
666666
return self._get_metadata_property(PROPERTY_PROFILE)
667667

668668
@profile.setter
669-
def profile(self, value: str) -> None:
669+
def profile(self, value: Optional[str | None]) -> None:
670670
self._set_metadata_property(PROPERTY_PROFILE, value)
671671

672672
@property

tests/test_model_sbom_component.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ def test_property_setters(self) -> None:
5858
self.assertEqual("42.42", component.version)
5959

6060
component.purl = PackageURL(type="generic", name="foo.zip")
61-
self.assertEqual("foo.zip", component.purl.name)
61+
if component.purl is not None:
62+
self.assertEqual("foo.zip", component.purl.name)
63+
else:
64+
self.fail("component.purl should not be None")
6265

6366
component.add_author(OrganizationalContact(name="Lex Luthor"))
6467
self.assertEqual("Lex Luthor", component.authors[0].name)
@@ -93,16 +96,16 @@ def test_direct_dependency(self) -> None:
9396
component = SbomComponent(Component(name="test"))
9497
self.assertFalse(component.direct_dependency)
9598

96-
component.direct_dependency = "true" # type: ignore[assignment]
99+
component.direct_dependency = "true"
97100
self.assertTrue(component.direct_dependency)
98101

99-
component.direct_dependency = "True" # type: ignore[assignment]
102+
component.direct_dependency = "True"
100103
self.assertTrue(component.direct_dependency)
101104

102-
component.direct_dependency = "False" # type: ignore[assignment]
105+
component.direct_dependency = "False"
103106
self.assertFalse(component.direct_dependency)
104107

105-
component.direct_dependency = "something" # type: ignore[assignment]
108+
component.direct_dependency = "something"
106109
self.assertFalse(component.direct_dependency)
107110

108111
def test_internal(self) -> None:

tests/test_v3_parser_write.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def test_write_with_set_licenses(self) -> None:
152152
))
153153

154154
licenses = [LicenseExpression("MIT")]
155-
comp.licenses = licenses # type: ignore[assignment] # this is a mypy issue
155+
comp.licenses = licenses
156156

157157
sbom.add_component(comp)
158158
StandardBomParser.save(sbom, output_filename, with_dependencies=False)

0 commit comments

Comments
 (0)