Changes to site should recreate sigsci_edge_deployment_service resource

[sjparkinson]

Per https://docs.fastly.com/en/ngwaf/edge-waf-deployment-using-the-next-gen-waf-control-panel#re-mapping-a-fastly-vcl-service-to-a-new-site-workspace, in order to move a Fastly service between sites in Signal Sciences the provider should send a DELETE then a PUT request to the deliveryIntegration endpoint.

terraform-provider-sigsci/provider/resource_edge_deployment_service.go

Lines 16 to 20 in c94c12f

	"site_short_name": {
	Type: schema.TypeString,
	Description: "Site short name",
	Required: true,
	},

I think this is solved by making use of ForceNew¹.

Currently we're looking to work around this using:

# To enable the use of `replace_triggered_by` in the `sigsci_edge_deployment_service` resource.
resource "terraform_data" "sigsci_site" {
  input = var.sigsci_site
}

resource "sigsci_edge_deployment_service" "this" {
  site_short_name = terraform_data.sigsci_site
  fastly_sid      = fastly_service_vcl.this.id
  percent_enabled = 100

  lifecycle {
    replace_triggered_by = [
      # The provider does not correctly handle changes to the `site_short_name` attribute. A DELETE then PUT request
      # is required to move services between sites.
      terraform_data.sigsci_site,
    ]
  }
}

Footnotes

1. https://developer.hashicorp.com/terraform/plugin/sdkv2/schemas/schema-behaviors#forcenew ↩