[REFACTOR] golang Analyzer modernize:

Gonzalo Diaz · Gonzalo Diaz · commit 4d9fc7811615 · 2025-05-08T23:14:39.000-04:00
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -apply ./...
diff --git a/exercises/hackerrank/interview_preparation_kit/arrays/2d_array.go b/exercises/hackerrank/interview_preparation_kit/arrays/2d_array.go
@@ -36,7 +36,7 @@ func hourglassSum(arr [][]int32) int32 {
 		for j := int32(matrixStartIndex); j <= int32(matrixEndIndex); j++ {
 			var currentHourglassSum int32 = 0
 			currentHourglass := getHourGlass(arr, i, j)
-			for k := 0; k < len(currentHourglass); k++ {
+			for k := range currentHourglass {
 				currentHourglassSum += currentHourglass[k]
 			}
 
diff --git a/exercises/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.go b/exercises/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.go
@@ -18,7 +18,7 @@ func rotLeft(a []int32, d int32) []int32 {
 	x := a[:]
 	var i int32
 
-	for i = 0; i < d; i++ {
+	for i = range d {
 		x = rotLeftOne(x)
 	}
 	return x
diff --git a/exercises/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/count-triplets-1.go b/exercises/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/count-triplets-1.go
@@ -7,7 +7,7 @@ package hackerrank
 func countTripletsBruteForce(arr []int64, r int64) int64 {
 	size := len(arr)
 	counter := int64(0)
-	for i := 0; i < size-2; i++ {
+	for i := range size - 2 {
 		for j := i + 1; j < size-1; j++ {
 			for k := j + 1; k < size; k++ {
 				if r*arr[i] == arr[j] && r*arr[j] == arr[k] {
diff --git a/exercises/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/sherlock-and-anagrams.go b/exercises/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/sherlock-and-anagrams.go
@@ -27,8 +27,8 @@ func sherlockAndAnagrams(s string) int32 {
 	candidates := make(map[string][]string)
 	size := len(s)
 
-	for i := 0; i < size; i++ {
-		for j := 0; j < size-i; j++ {
+	for i := range size {
+		for j := range size - i {
 			substr := s[i : size-j]
 
 			log.Debug("i: %d, size: %d, size - j: %d | substr: %s",
diff --git a/exercises/hackerrank/warmup/aVeryBigSum.go b/exercises/hackerrank/warmup/aVeryBigSum.go
@@ -9,7 +9,7 @@ import "gon.cl/algorithms/utils/log"
 func AVeryBigSum(ar []uint64) uint64 {
 	var result uint64 = 0
 
-	for i := 0; i < len(ar); i++ {
+	for i := range ar {
 		result += ar[i]
 	}
 
diff --git a/exercises/hackerrank/warmup/compareTriplets.go b/exercises/hackerrank/warmup/compareTriplets.go
@@ -18,7 +18,7 @@ func CompareTriplets(a []int, b []int) ([]int, error) {
 
 	var awards = []int{0, 0}
 
-	for i := 0; i < len(a); i++ {
+	for i := range a {
 		if a[i] > b[i] {
 			awards[0] = awards[0] + 1
 		}
diff --git a/exercises/hackerrank/warmup/diagonalDifference.go b/exercises/hackerrank/warmup/diagonalDifference.go
@@ -15,8 +15,8 @@ func DiagonalDifference(arr [][]int) int {
 	diag2 := 0
 	last := len(arr) - 1
 
-	for i := 0; i < len(arr); i++ {
-		for j := 0; j < len(arr); j++ {
+	for i := range arr {
+		for j := range arr {
 			if i == j {
 				diag1 += arr[i][j]
 				diag2 += arr[last-i][j]
diff --git a/exercises/hackerrank/warmup/miniMaxSum.go b/exercises/hackerrank/warmup/miniMaxSum.go
@@ -18,7 +18,7 @@ func MiniMaxSum(arr []int) (string, error) {
 	min := arr[0]
 	max := arr[1]
 
-	for i := 0; i < len(arr); i++ {
+	for i := range arr {
 		num := arr[i]
 		sum += num
 
diff --git a/exercises/hackerrank/warmup/simpleArraySum.go b/exercises/hackerrank/warmup/simpleArraySum.go
@@ -9,7 +9,7 @@ import "gon.cl/algorithms/utils/log"
 func SimpleArraySum(arr []int) int {
 	acum := 0
 
-	for i := 0; i < len(arr); i++ {
+	for i := range arr {
 		acum += arr[i]
 	}
 
diff --git a/exercises/projecteuler/helpers/divisors.go b/exercises/projecteuler/helpers/divisors.go
@@ -5,6 +5,7 @@ import (
 	"sort"
 
 	"gon.cl/algorithms/utils/log"
+	"slices"
 )
 
 type Factor struct {
@@ -53,7 +54,7 @@ func Divisors(target int) []int {
 	log.Debug("collected divisors %x", divs)
 
 	// sort divisors
-	sort.Slice(divs, func(i, j int) bool { return divs[i] < divs[j] })
+	slices.Sort(divs)
 	log.Debug("sorted divisors %x", divs)
 
 	return divs
diff --git a/exercises/projecteuler/helpers/matrix.go b/exercises/projecteuler/helpers/matrix.go
@@ -3,9 +3,9 @@ package helpers
 func Matrix(m int, n int, init int) [][]int {
 	var matrix [][]int
 
-	for i := 0; i < m; i++ {
+	for range m {
 		row := []int{}
-		for j := 0; j < n; j++ {
+		for range n {
 			row = append(row, init)
 		}
 		matrix = append(matrix, row)
diff --git a/exercises/projecteuler/helpers/sum.go b/exercises/projecteuler/helpers/sum.go
@@ -4,7 +4,7 @@ func Sum(listOfNums []int) int {
 
 	var sum int
 
-	for i := 0; i < len(listOfNums); i++ {
+	for i := range listOfNums {
 		sum += listOfNums[i]
 	}
 
diff --git a/exercises/projecteuler/problem0001.go b/exercises/projecteuler/problem0001.go
@@ -11,7 +11,7 @@ import (
 func Problem0001(top int) int {
 	total := 0
 
-	for i := 0; i < top; i++ {
+	for i := range top {
 		if i%3 == 0 || i%5 == 0 {
 
 			total += i
diff --git a/exercises/projecteuler/problem0008.go b/exercises/projecteuler/problem0008.go
@@ -34,7 +34,7 @@ func Problem0008(numberInput string) int {
 	for i := bottom; i <= top-interval; i += 1 {
 		var digitsSet []int
 
-		for j := 0; j < interval; j++ {
+		for j := range interval {
 			digitsSet = append(digitsSet, int(digitsSlice[i+j]))
 		}
 
diff --git a/exercises/projecteuler/problem0022.go b/exercises/projecteuler/problem0022.go
@@ -19,7 +19,7 @@ func Problem0022(listOfNames []string) int {
 
 	sort.Strings(listOfNames)
 
-	for i := 0; i < len(listOfNames); i++ {
+	for i := range listOfNames {
 		answer += (i + 1) * helpers.WordScore(listOfNames[i])
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ func hourglassSum(arr [][]int32) int32 {`
`36`	`36`	`for j := int32(matrixStartIndex); j <= int32(matrixEndIndex); j++ {`
`37`	`37`	`var currentHourglassSum int32 = 0`
`38`	`38`	`currentHourglass := getHourGlass(arr, i, j)`
`39`		`- for k := 0; k < len(currentHourglass); k++ {`
	`39`	`+ for k := range currentHourglass {`
`40`	`40`	`currentHourglassSum += currentHourglass[k]`
`41`	`41`	`}`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ func rotLeft(a []int32, d int32) []int32 {`
`18`	`18`	`x := a[:]`
`19`	`19`	`var i int32`
`20`	`20`
`21`		`- for i = 0; i < d; i++ {`
	`21`	`+ for i = range d {`
`22`	`22`	`x = rotLeftOne(x)`
`23`	`23`	`}`
`24`	`24`	`return x`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ import "gon.cl/algorithms/utils/log"`
`9`	`9`	`func AVeryBigSum(ar []uint64) uint64 {`
`10`	`10`	`var result uint64 = 0`
`11`	`11`
`12`		`- for i := 0; i < len(ar); i++ {`
	`12`	`+ for i := range ar {`
`13`	`13`	`result += ar[i]`
`14`	`14`	`}`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ func CompareTriplets(a []int, b []int) ([]int, error) {`
`18`	`18`
`19`	`19`	`var awards = []int{0, 0}`
`20`	`20`
`21`		`- for i := 0; i < len(a); i++ {`
	`21`	`+ for i := range a {`
`22`	`22`	`if a[i] > b[i] {`
`23`	`23`	`awards[0] = awards[0] + 1`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ import "gon.cl/algorithms/utils/log"`
`9`	`9`	`func SimpleArraySum(arr []int) int {`
`10`	`10`	`acum := 0`
`11`	`11`
`12`		`- for i := 0; i < len(arr); i++ {`
	`12`	`+ for i := range arr {`
`13`	`13`	`acum += arr[i]`
`14`	`14`	`}`
`15`	`15`