Merge pull request #224 from zenoleg/fix/db-exception-in-body

fix(statement): Avoid Marking Responses as Failed When Data Contains DB::Exception Text as a Value

Author: isublimity

src/Statement.php

@@ -152,9 +152,18 @@ private function parseErrorClickHouse(string $body)
         return false;
     }
 
-    private function hasErrorClickhouse(string $body): bool {
+    private function hasErrorClickhouse(string $body, string $contentType): bool {
+        if (false === stripos($contentType, 'application/json')) {
+            return preg_match(self::CLICKHOUSE_ERROR_REGEX, $body) === 1;
+        }
 
-        return preg_match(self::CLICKHOUSE_ERROR_REGEX, $body) === 1;
+        try {
+            json_decode($body, true, 512, JSON_THROW_ON_ERROR);
+        } catch (\JsonException $e) {
+            return true;
+        }
+
+        return false;
     }
 
     /**
@@ -214,7 +223,7 @@ public function isError(): bool
             return true;
         }
 
-        if ($this->hasErrorClickhouse($this->response()->body())) {
+        if ($this->hasErrorClickhouse($this->response()->body(), $this->response()->content_type())) {
             return true;
         }
 

tests/StatementTest.php

@@ -50,6 +50,26 @@ public function testIsErrorWithOkStatusCode()
         $this->assertTrue($result->isError());
     }
 
+    /**
+     * @link https://github.com/smi2/phpClickHouse/issues/223
+     * @see src/Statement.php:14
+     *
+     * The response data may legitimately contain text that matches the
+     * CLICKHOUSE_ERROR_REGEX pattern. This is particularly common when querying
+     * system tables like system.mutations, where error messages are stored as data
+     */
+    public function testIsNotErrorWhenJsonBodyContainsDbExceptionMessage()
+    {
+        $result = $this->client->select(
+            "SELECT 
+                    'mutation_123456' AS mutation_id,
+                    'Code: 243. DB::Exception: Cannot reserve 61.64 GiB, not enough space. (NOT_ENOUGH_SPACE) (version 24.3.2.23 (official build))' AS latest_fail_reason"
+        );
+
+        $this->assertEquals(200, $result->getRequest()->response()->http_code());
+        $this->assertFalse($result->isError());
+    }
+
     /**
      * @dataProvider dataProvider
      */