Skip to content

Commit bceab01

Browse files
MyMomSaysIAmSpecialdarrachequesne
authored andcommitted
[fix] Fix duplicate identifier declaration (#213)
1 parent 2354068 commit bceab01

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

index.js

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -233,31 +233,27 @@ function adapter(uri, opts) {
233233
var socket = this.nsp.connected[request.sid];
234234
if (!socket) { return; }
235235

236-
function sendAck(){
236+
socket.join(request.room, function(){
237237
var response = JSON.stringify({
238238
requestid: request.requestid
239239
});
240240

241241
pub.publish(self.responseChannel, response);
242-
}
243-
244-
socket.join(request.room, sendAck);
242+
});
245243
break;
246244

247245
case requestTypes.remoteLeave:
248246

249247
var socket = this.nsp.connected[request.sid];
250248
if (!socket) { return; }
251249

252-
function sendAck(){
250+
socket.leave(request.room, function(){
253251
var response = JSON.stringify({
254252
requestid: request.requestid
255253
});
256254

257255
pub.publish(self.responseChannel, response);
258-
}
259-
260-
socket.leave(request.room, sendAck);
256+
});
261257
break;
262258

263259
case requestTypes.remoteDisconnect:

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"expect.js": "0.3.1",
2626
"ioredis": "2.5.0",
2727
"mocha": "3.2.0",
28-
"socket.io": "socketio/socket.io",
29-
"socket.io-client": "socketio/socket.io-client"
28+
"socket.io": "1.7.x",
29+
"socket.io-client": "1.7.x"
3030
}
3131
}

0 commit comments

Comments
 (0)