Skip to content

feat: Allow to use an existing translator #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

feat: Allow to use an existing translator #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c18139
feat: Allow to use an existing translator
Crovitche-1623 Sep 8, 2025
7aec814
refactor: respect parameters order to preserve BC
Crovitche-1623 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/TranslationDriver/SymfonyTranslationDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use Symfony\Component\Translation\Loader\MoFileLoader;
use Symfony\Component\Translation\Translator;
use Symfony\Contracts\Translation\TranslatorInterface;

class SymfonyTranslationDriver implements TranslationDriverInterface
{
Expand All @@ -19,9 +20,12 @@ class SymfonyTranslationDriver implements TranslationDriverInterface
*/
private $locale = 'en';

public function __construct(?string $cacheDirectory = null)
/**
* @param string|null $cacheDirectory useful only if the given $translator is null.
*/
public function __construct(?string $cacheDirectory = null, ?TranslatorInterface $translator = null)
{
$this->translator = new Translator($this->locale, null, $cacheDirectory);
$this->translator = $translator ?: new Translator($this->locale, null, $cacheDirectory);
$this->translator->addLoader('mo', new MoFileLoader());
}

Expand Down