Skip to content

Conversation

@JayTheXXVII
Copy link

@JayTheXXVII JayTheXXVII commented Nov 11, 2025

Added RTL-Legacy to Snippets & added Resources

Summary by CodeRabbit

  • New Features
    • RTL-Legacy snippet now available for RevertX2-Legacy users on Spotify version 1.2.45.454
    • Includes customizable UI styling options with visual preview

Added RTL-Legacy.png
Added RTL-Legacy, Intended To Be Used With RevertX2-Legacy *Only for Spotify version 1.2.45.454* Which relocates the right sidebar to the left.
@JayTheXXVII JayTheXXVII requested a review from a team as a code owner November 11, 2025 05:30
@JayTheXXVII JayTheXXVII requested review from Delusoire and removed request for a team November 11, 2025 05:30
@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Walkthrough

A new snippet entry titled "RTL-Legacy" was added to the snippets JSON file. The entry includes CSS styling rules for UI customization, a description linking it to RevertX2-Legacy for Spotify version 1.2.45.454, and references a preview image asset.

Changes

Cohort / File(s) Summary
New Snippet Entry
resources/snippets.json
Added RTL-Legacy snippet object with CSS rules, description referencing RevertX2-Legacy (Spotify v1.2.45.454), and preview image reference

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single JSON object addition with no modifications to existing entries
  • No logic or control flow changes
  • Straightforward data insertion following existing schema

Poem

A snippet so new, with styles so sleek,
For legacy code, both bold and unique,
RTL tweaks in CSS divine,
The rabbit hops forth with this design! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'feat(snippets): rtl-legacy' directly matches the main change—adding a new RTL-Legacy snippet entry to the snippets collection.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JayTheXXVII JayTheXXVII changed the title RTL-Legacy feat: RTL-Legacy Nov 11, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
resources/snippets.json (1)

2-7: Asset verified; maintain CSS documentation and version compatibility tracking.

The preview asset exists and the title is unique, so no structural issues found. However, consider these best practices:

  1. CSS maintainability: The minified CSS code (1,700+ characters) is difficult to read or modify. Document the source or maintain a formatted version for reference.
  2. Version tracking: The description ties this snippet to Spotify version 1.2.45.454 specifically. Establish a mechanism to flag or deprecate this snippet if it becomes incompatible with newer Spotify versions.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 479e43d and c8fa47e.

⛔ Files ignored due to path filters (1)
  • resources/assets/snippets/RTL-Legacy.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • resources/snippets.json (1 hunks)

@JayTheXXVII
Copy link
Author

JayTheXXVII commented Nov 11, 2025

I see the Lint error stating "Error: The subject "RTL-Legacy" found in pull request title "feat: RTL-Legacy" doesn't match the configured pattern "^(?![A-Z]).+$"."

I am not sure what to do to fix this error myself, any tips would be awesome.

edit: I removed capital letters from title to resolve issue

@JayTheXXVII JayTheXXVII changed the title feat: RTL-Legacy feat(snippets): RTL-Legacy Nov 11, 2025
@JayTheXXVII
Copy link
Author

As for Nitpick "CSS maintainability: The minified CSS code (1,700+ characters) is difficult to read or modify. Document the source or maintain a formatted version for reference."

it is available Here, also linked in initial comment

@JayTheXXVII JayTheXXVII changed the title feat(snippets): RTL-Legacy feat(snippets): rtl-legacy Nov 11, 2025
@rxri
Copy link
Member

rxri commented Nov 11, 2025

Since it's intended to be used with another extension, bundle it with that extension.

@rxri rxri closed this Nov 11, 2025
@JayTheXXVII
Copy link
Author

It works as a standalone too, but I built this using my RevertX2-Legacy theme enabled and using Spotify version 1.2.45.454.
I realize that I mistakenly portrayed the snippets description and updated it accordingly.
I say "intended" as it has full compatibility with RevertX2-Legacy, being based on it.
Is there any way for us to work around this miscommunication on my behalf?

@rxri
Copy link
Member

rxri commented Nov 12, 2025

I see, however having a snippet only work for one version is not feasible to have. Descriptions get trimmed based on the viewport size and this may not always be even seen - as if people do not read already. I still believe it should be shipped with your extension as available addon. If this would've been a v3 "module" then yeah - it would be nice because you could've specified the version it works on but its nowhere in production version rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants