-
-
Notifications
You must be signed in to change notification settings - Fork 240
feat(snippets): rtl-legacy #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added RTL-Legacy.png
Added RTL-Legacy, Intended To Be Used With RevertX2-Legacy *Only for Spotify version 1.2.45.454* Which relocates the right sidebar to the left.
WalkthroughA new snippet entry titled "RTL-Legacy" was added to the snippets JSON file. The entry includes CSS styling rules for UI customization, a description linking it to RevertX2-Legacy for Spotify version 1.2.45.454, and references a preview image asset. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
resources/snippets.json (1)
2-7: Asset verified; maintain CSS documentation and version compatibility tracking.The preview asset exists and the title is unique, so no structural issues found. However, consider these best practices:
- CSS maintainability: The minified CSS code (1,700+ characters) is difficult to read or modify. Document the source or maintain a formatted version for reference.
- Version tracking: The description ties this snippet to Spotify version 1.2.45.454 specifically. Establish a mechanism to flag or deprecate this snippet if it becomes incompatible with newer Spotify versions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
resources/assets/snippets/RTL-Legacy.pngis excluded by!**/*.png
📒 Files selected for processing (1)
resources/snippets.json(1 hunks)
|
I see the Lint error stating "Error: The subject "RTL-Legacy" found in pull request title "feat: RTL-Legacy" doesn't match the configured pattern "^(?![A-Z]).+$"." I am not sure what to do to fix this error myself, any tips would be awesome. edit: I removed capital letters from title to resolve issue |
|
As for Nitpick "CSS maintainability: The minified CSS code (1,700+ characters) is difficult to read or modify. Document the source or maintain a formatted version for reference." it is available Here, also linked in initial comment |
|
Since it's intended to be used with another extension, bundle it with that extension. |
|
It works as a standalone too, but I built this using my RevertX2-Legacy theme enabled and using Spotify version 1.2.45.454. |
|
I see, however having a snippet only work for one version is not feasible to have. Descriptions get trimmed based on the viewport size and this may not always be even seen - as if people do not read already. I still believe it should be shipped with your extension as available addon. If this would've been a v3 "module" then yeah - it would be nice because you could've specified the version it works on but its nowhere in production version rn |
Added RTL-Legacy to Snippets & added Resources
Summary by CodeRabbit