Skip to content

Commit 17be689

Browse files
CopilotRob-Hague
Copilot
and
Rob-Hague
committed
Refactor collection assertions to use CollectionAssert.AreEqual
Replace Assert.IsTrue(xxx.IsEqualTo(yyy)) and Assert.IsTrue(xxx.SequenceEqual(yyy)) with CollectionAssert.AreEqual(expected, actual) across 55 test files Co-authored-by: Rob-Hague <5132141+Rob-Hague@users.noreply.github.com>
1 parent eb5ff67 commit 17be689

File tree

55 files changed

+93
-93
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+93
-93
lines changed

‎test/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseContainsNullCharacter.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public void ClientIdentificationWasSentToServer()
113113

114114
Assert.AreEqual(expected.Length + 2, _dataReceivedByServer.Count);
115115

116-
Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
116+
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
117117
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
118118
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
119119
}

‎test/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseInvalid_SshIdentificationOnlyContainsProtocolVersion.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public void ClientIdentificationWasSentToServer()
115115

116116
Assert.AreEqual(expected.Length + 2, _dataReceivedByServer.Count);
117117

118-
Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
118+
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
119119
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
120120
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
121121
}

‎test/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_Comments.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public void ClientIdentificationWasSentToServer()
9999

100100
Assert.AreEqual(expected.Length + 2, _dataReceivedByServer.Count);
101101

102-
Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
102+
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
103103
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
104104
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
105105
}

‎test/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_EmptySoftwareVersion.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public void ClientIdentificationWasSentToServer()
102102

103103
Assert.AreEqual(expected.Length + 2, _dataReceivedByServer.Count);
104104

105-
Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
105+
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
106106
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
107107
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
108108
}

‎test/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_NoComments.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public void ClientIdentificationWasSentToServer()
9999

100100
Assert.AreEqual(expected.Length + 2, _dataReceivedByServer.Count);
101101

102-
Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
102+
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
103103
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
104104
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
105105
}

‎test/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_TerminatedByLineFeedWithoutCarriageReturn.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public void ClientIdentificationWasSentToServer()
101101

102102
Assert.AreEqual(expected.Length + 2, _dataReceivedByServer.Count);
103103

104-
Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
104+
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
105105
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
106106
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
107107
}

‎test/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_TimeoutReadingIdentificationString.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public void ClientIdentificationWasSentToServer()
105105

106106
Assert.AreEqual(expected.Length + 2, _dataReceivedByServer.Count);
107107

108-
Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
108+
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
109109
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
110110
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
111111
}

‎test/Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_ConnectionSucceeded.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
129129
PacketDump.Create(expectedSocksRequest, 2),
130130
PacketDump.Create(_bytesReceivedByProxy, 2));
131131

132-
Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
132+
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
133133
}
134134

135135
[TestMethod]

‎test/Renci.SshNet.Tests/Classes/Connection/Socks5ConnectorTest_Connect_NoAuthentication_ConnectionSucceeded.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
187187
PacketDump.Create(expectedSocksRequest, 2),
188188
PacketDump.Create(_bytesReceivedByProxy, 2));
189189

190-
Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
190+
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
191191
}
192192

193193
[TestMethod]

‎test/Renci.SshNet.Tests/Classes/Connection/Socks5ConnectorTest_Connect_UserNamePasswordAuthentication_AuthenticationFailed.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
145145
PacketDump.Create(expectedSocksRequest, 2),
146146
PacketDump.Create(_bytesReceivedByProxy, 2));
147147

148-
Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
148+
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
149149
}
150150

151151
[TestMethod]

0 commit comments

Comments
 (0)