Skip to content

Conversation

@rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Nov 7, 2025

Description

relates to STACKITTPR-410

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner November 7, 2025 10:17
@rubenhoenle rubenhoenle force-pushed the feat/STACKITTPR-410-kms-onboarding-keyring branch from ec371db to 1c77bbd Compare November 7, 2025 10:21
@rubenhoenle rubenhoenle self-assigned this Nov 7, 2025
@rubenhoenle rubenhoenle force-pushed the feat/STACKITTPR-410-kms-onboarding-keyring branch 2 times, most recently from 7f70bc6 to d667641 Compare November 11, 2025 11:02
@rubenhoenle rubenhoenle force-pushed the feat/STACKITTPR-410-kms-onboarding-keyring branch from 3653e0e to 90e6cc4 Compare November 12, 2025 11:23
@rubenhoenle rubenhoenle force-pushed the feat/STACKITTPR-410-kms-onboarding-keyring branch from 90e6cc4 to 21a82e5 Compare November 12, 2025 13:08
@rubenhoenle rubenhoenle enabled auto-merge (squash) November 12, 2025 13:08
@rubenhoenle rubenhoenle merged commit edf22a6 into main Nov 12, 2025
5 checks passed
@rubenhoenle rubenhoenle deleted the feat/STACKITTPR-410-kms-onboarding-keyring branch November 12, 2025 13:10
@github-actions
Copy link

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit 1.85% (-0.03%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core 29.63% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring 10.98% (+10.98%) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/utils 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil 7.03% (-0.17%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core/core.go 29.63% (ø) 27 8 19
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring/datasource.go 0.00% (ø) 37 (+37) 0 37 (+37)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring/resource.go 14.17% (+14.17%) 127 (+127) 18 (+18) 109 (+109) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/utils/util.go 0.00% (ø) 8 (+8) 0 8 (+8)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil/testutil.go 7.03% (-0.17%) 128 (+3) 9 119 (+3) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go 1.85% (-0.03%) 108 (+2) 2 106 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/kms_acc_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants