Skip to content

Conversation

@avorylli
Copy link

Replace incorrect field names (address, tokenAddress) with token_address in React example and output sample.

Add null check for gasToken before use.

Fix matches the actual TokenData interface structure.

Copy link
Collaborator

@PhilippeR26 PhilippeR26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially legit.
Added a commit to

  • Adapt WalletAccount to starknet.js v8
  • Remove check of gasToken (defined by design) and add !

}

const onClickExecute = () => {
if (!gasToken) return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary. See L294

@avorylli avorylli requested a review from PhilippeR26 November 14, 2025 12:18
@PhilippeR26
Copy link
Collaborator

PhilippeR26 commented Nov 14, 2025

Why have you removed || !gasToken in disabled={loading || !gasToken} ?

@avorylli
Copy link
Author

Why have you removed || !gasToken in disabled={loading || !gasToken} ?

oops, my mistake, thought the 245 should be and 294 deleted, nevermind, reverted commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants