Skip to content

Conversation

@Sj-Si
Copy link
Contributor

@Sj-Si Sj-Si commented Nov 11, 2025

Brief

This PR adds a function that can easily get the filled percentage of the energy bar.

Tested in both campaign scenarios.

Would be useful to check energy prior to even attempting training analysis in order to rest immediately when energy is below some threshold. Previously, the energy was being estimated from failure chance so I was planning on this replacing that process, but it seems like that may have been removed during the most recent change. I still think it would be nice to have this function available for future use.

@steve1316 steve1316 self-requested a review November 11, 2025 22:30
@steve1316 steve1316 self-assigned this Nov 11, 2025
@steve1316 steve1316 added the enhancement New feature or request label Nov 11, 2025
@github-project-automation github-project-automation bot moved this to In progress in My TODO List Nov 11, 2025
@github-project-automation github-project-automation bot moved this from In progress to Review in progress in My TODO List Nov 11, 2025
@steve1316
Copy link
Owner

I was planning on this replacing that process, but it seems like that may have been removed during the most recent change.

Nothing has been changed regarding this on my end so your approach will indeed make this much faster than checking the failure chance and then backing out to the main screen.

Copy link
Owner

@steve1316 steve1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve and merge this. LGTM and will lead to quicker trainings overall.

@github-project-automation github-project-automation bot moved this from Review in progress to Reviewer approved in My TODO List Nov 12, 2025
@steve1316 steve1316 merged commit 410a2f6 into steve1316:master Nov 12, 2025
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in My TODO List Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants