FIX(supabase_flutter): use getInitialAppLink from app_links #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was trying to support multiple versions of the app_links package, but it was causing a NoSuchMethodError when using newer versions. This commit removes the backward compatibility logic and uses the getInitialAppLink method directly, which is available in app_links ^4.0.0 and later.
Pull Request Test Coverage Report for Build 16531665980Details
💛 - Coveralls |
MikaelDDavidd
changed the title
|
I'm a fan of removing support for the old versions, but this pr sets the version to only ^4.0.0 Although there are newer versions which we want to support as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was trying to support multiple versions of the app_links package, but it was causing a NoSuchMethodError when using newer versions.
This commit removes the backward compatibility logic and uses the getInitialAppLink method directly, which is available in app_links ^4.0.0 and later.
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.