Skip to content

Commit b63caad

Browse files
sync
1 parent 7b2b447 commit b63caad

File tree

2 files changed

+38
-7
lines changed

2 files changed

+38
-7
lines changed

JOURNAL.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,23 @@
11
# Engineering Journal
22

3+
## 2025-01-18 (v1.1.1)
4+
5+
### Fixed Security Scan Prompt Logic When User Declines
6+
- **What**: Fixed issue where security scan instruction appeared in recommended next step even when user chose "N"
7+
- **Why**: User reported that declining security scan still showed security scan instructions in the prompt
8+
- **How**: Added conditional logic to check if user chose security checkup and only include security scan text when appropriate
9+
- **Issues**: None - clean implementation
10+
- **Result**: Recommended prompt now correctly excludes security scan instruction when user declines
11+
12+
### Added Contributors Link to Thank You Message
13+
- **What**: Added link to THANKS.md at the end of initialization script
14+
- **Why**: Acknowledge contributors and make it easy for users to see who helped build the project
15+
- **How**: Updated animateThankYou() function to include contributor message with link to THANKS.md
16+
- **Issues**: None
17+
- **Result**: Users now see "Made with ❤️ by our amazing contributors" with link to recognition page
18+
19+
---
20+
321
## 2025-01-14 19:15
422

523
### Added Legal Disclaimer to README

bin/init.js

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,7 @@ async function initializeFramework(targetDir, options) {
330330
console.log('');
331331

332332
// Ask if they want to run a health check
333+
let userChoseSecurityCheckup = false;
333334
if (!options.yes) {
334335
console.log('');
335336
console.log(chalk.cyan('┌─────────────────────────────────────────────────────────────────┐'));
@@ -341,6 +342,7 @@ async function initializeFramework(targetDir, options) {
341342
console.log('');
342343

343344
const runCheckup = await promptConfirmation(chalk.yellow('Run security checkup? (y/N): '));
345+
userChoseSecurityCheckup = runCheckup;
344346

345347
if (runCheckup) {
346348
console.log('');
@@ -356,13 +358,21 @@ async function initializeFramework(targetDir, options) {
356358
console.log(chalk.yellow('│') + ' ask Claude Code: ' + chalk.yellow('│'));
357359
console.log(chalk.yellow('│') + ' ' + chalk.yellow('│'));
358360
console.log(chalk.yellow('│') + chalk.cyan(' "Please review this codebase and update the CLAUDE.md') + ' ' + chalk.yellow('│'));
359-
console.log(chalk.yellow('│') + chalk.cyan(' and CONDUCTOR.md files with the actual project details.') + ' ' + chalk.yellow('│'));
360-
console.log(chalk.yellow('│') + chalk.cyan(' Also perform a security health check and list any') + ' ' + chalk.yellow('│'));
361-
console.log(chalk.yellow('│') + chalk.cyan(' potential vulnerabilities or concerns (like exposed') + ' ' + chalk.yellow('│'));
362-
console.log(chalk.yellow('│') + chalk.cyan(' .env files, API keys in code, missing .gitignore') + ' ' + chalk.yellow('│'));
363-
console.log(chalk.yellow('│') + chalk.cyan(' entries, outdated dependencies with known vulnerabilities,') + ' ' + chalk.yellow('│'));
364-
console.log(chalk.yellow('│') + chalk.cyan(' or insecure configurations) - just list them as warnings,') + ' ' + chalk.yellow('│'));
365-
console.log(chalk.yellow('│') + chalk.cyan(' don\'t fix anything."') + ' ' + chalk.yellow('│'));
361+
362+
if (userChoseSecurityCheckup && !options.yes) {
363+
// User already ran security checkup, so don't include it in the prompt
364+
console.log(chalk.yellow('│') + chalk.cyan(' and CONDUCTOR.md files with the actual project details."') + ' ' + chalk.yellow('│'));
365+
} else {
366+
// User didn't run security checkup OR used --yes flag, so include it in the prompt
367+
console.log(chalk.yellow('│') + chalk.cyan(' and CONDUCTOR.md files with the actual project details.') + ' ' + chalk.yellow('│'));
368+
console.log(chalk.yellow('│') + chalk.cyan(' Also perform a security health check and list any') + ' ' + chalk.yellow('│'));
369+
console.log(chalk.yellow('│') + chalk.cyan(' potential vulnerabilities or concerns (like exposed') + ' ' + chalk.yellow('│'));
370+
console.log(chalk.yellow('│') + chalk.cyan(' .env files, API keys in code, missing .gitignore') + ' ' + chalk.yellow('│'));
371+
console.log(chalk.yellow('│') + chalk.cyan(' entries, outdated dependencies with known vulnerabilities,') + ' ' + chalk.yellow('│'));
372+
console.log(chalk.yellow('│') + chalk.cyan(' or insecure configurations) - just list them as warnings,') + ' ' + chalk.yellow('│'));
373+
console.log(chalk.yellow('│') + chalk.cyan(' don\'t fix anything."') + ' ' + chalk.yellow('│'));
374+
}
375+
366376
console.log(chalk.yellow('│') + ' ' + chalk.yellow('│'));
367377
console.log(chalk.yellow('│') + ' This one-time setup ensures your docs match your project! 🚀 ' + chalk.yellow('│'));
368378
console.log(chalk.yellow('└─────────────────────────────────────────────────────────────────┘'));
@@ -408,6 +418,9 @@ async function animateThankYou() {
408418
console.log('');
409419
console.log(chalk.gray(' Happy documenting with Claude!'));
410420
console.log('');
421+
console.log(chalk.gray(' Improved with contributions from our amazing contributors'));
422+
console.log(chalk.gray(' See: ') + chalk.blue.underline('https://github.com/superbasicstudio/claude-conductor/blob/main/THANKS.md'));
423+
console.log('');
411424
}
412425

413426
async function copyTemplates(templatesDir, targetPath, force, full = false, newlyCreatedFiles) {

0 commit comments

Comments
 (0)