Enforce canInitiatePaymentsToNewBeneficiaries for standing orders #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fixed the issue where users could create standing orders with new beneficiaries even when `canInitiatePaymentsToNewBeneficiaries` was set to `false`. ### The Problem - `TransferRecurringWizard` always allowed entering new beneficiaries without checking permissions. - `canCreateStandingOrder` didn't check `canInitiatePaymentsToNewBeneficiaries`. ### The Solution Updated `TransferRecurringWizard` to match `TransferRegularWizard`: 1. Added a `BeneficiaryStep` component that checks `canInitiateCreditTransferToNewBeneficiary` (which includes `canInitiatePaymentsToNewBeneficiaries`). 2. Shows tabs for "New" and "Saved" beneficiaries. 3. Only shows the "New" tab if the user has permission to initiate payments to new beneficiaries. 4. Uses `SavedBeneficiariesForm` for selecting existing beneficiaries. Now, when `canInitiatePaymentsToNewBeneficiaries` is `false`, users can only create standing orders with existing saved beneficiaries, not new ones. The fix is complete and follows the same pattern used for regular credit transfers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the issue where users could create standing orders with new beneficiaries even when
canInitiatePaymentsToNewBeneficiarieswas set tofalse.The Problem
TransferRecurringWizardalways allowed entering new beneficiaries without checking permissions.canCreateStandingOrderdidn't checkcanInitiatePaymentsToNewBeneficiaries.The Solution
Updated
TransferRecurringWizardto matchTransferRegularWizard:BeneficiaryStepcomponent that checkscanInitiateCreditTransferToNewBeneficiary(which includescanInitiatePaymentsToNewBeneficiaries).SavedBeneficiariesFormfor selecting existing beneficiaries.Now, when
canInitiatePaymentsToNewBeneficiariesisfalse, users can only create standing orders with existing saved beneficiaries, not new ones.The fix is complete and follows the same pattern used for regular credit transfers.