[Notifier] Bring consistency to bridges

Author: nicolas-grekas

SmsapiTransport.php

@@ -64,28 +64,13 @@ public function setTest(bool $test): static
 
     public function __toString(): string
     {
-        $dsn = sprintf('smsapi://%s', $this->getEndpoint());
-        $params = [];
-
-        if ('' !== $this->from) {
-            $params['from'] = $this->from;
-        }
-
-        if ($this->fast) {
-            $params['fast'] = (int) $this->fast;
-        }
-
-        if ($this->test) {
-            $params['test'] = (int) $this->test;
-        }
-
-        $query = http_build_query($params, '', '&');
-
-        if ('' !== $query) {
-            $dsn .= sprintf('?%s', $query);
-        }
+        $query = array_filter([
+            'from' => $this->from,
+            'fast' => (int) $this->fast,
+            'test' => (int) $this->test,
+        ]);
 
-        return $dsn;
+        return sprintf('smsapi://%s%s', $this->getEndpoint(), $query ? '?'.http_build_query($query, '', '&') : '');
     }
 
     public function supports(MessageInterface $message): bool
@@ -109,10 +94,7 @@ protected function doSend(MessageInterface $message): SentMessage
             'test' => $this->test,
         ];
 
-        $from = $message->getFrom() ?: $this->from;
-
-        // if from is not empty add it to request body
-        if ('' !== $from) {
+        if ('' !== $from = $message->getFrom() ?: $this->from) {
             $body['from'] = $from;
         }