Skip to content

Commit 0fd5f65

Browse files
authored
Merge pull request #70 from tailflow/hotfix/force-deleting-trashed-entities
fix: force deleting a batch of trashed entities
2 parents 063f7c7 + b535228 commit 0fd5f65

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/Concerns/HandlesStandardBatchOperations.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ public function batchDestroy(Request $request)
151151

152152
$requestedRelations = $this->relationsResolver->requestedRelations($request);
153153

154-
$query = $this->buildBatchDestroyFetchQuery($request, $requestedRelations);
154+
$query = $this->buildBatchDestroyFetchQuery($request, $requestedRelations, $softDeletes);
155155
$entities = $this->runBatchDestroyFetchQuery($request, $query);
156156

157157
foreach ($entities as $entity) {
@@ -189,11 +189,15 @@ public function batchDestroy(Request $request)
189189
*
190190
* @param Request $request
191191
* @param array $requestedRelations
192+
* @param bool $softDeletes
192193
* @return Builder
193194
*/
194-
protected function buildBatchDestroyFetchQuery(Request $request, array $requestedRelations): Builder
195+
protected function buildBatchDestroyFetchQuery(Request $request, array $requestedRelations, bool $softDeletes): Builder
195196
{
196-
return $this->buildBatchFetchQuery($request, $requestedRelations);
197+
return $this->buildBatchFetchQuery($request, $requestedRelations)
198+
->when($softDeletes, function ($query) {
199+
$query->withTrashed();
200+
});
197201
}
198202

199203
/**

src/Testing/InteractsWithResources.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ protected function buildMetaLink(?string $url, $label, bool $active): array
459459
{
460460
return [
461461
'url' => $url,
462-
'label' => $label,
462+
'label' => (string) $label,
463463
'active' => $active
464464
];
465465
}

0 commit comments

Comments
 (0)