11.0.0 (#141)

* Drop node 8 and 9

* Add prefer-exponentiation-operator

Closes #118

* Add no-setter-return

Closes #117

* Add no-constructor-return

Closes #116

* Add grouped-accessor-pairs

Closes #115

* Ignore no-undefined in tests

* Update errors.js

Author: tclindner

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2
 jobs:
   build:
     docker:
-      - image: circleci/node:8
+      - image: circleci/node:12
     steps:
       - checkout
       - run: npm install
@@ -11,20 +11,6 @@ jobs:
           root: ~/
           paths:
             - project
-  test-node8:
-    docker:
-      - image: circleci/node:8
-    steps:
-      - attach_workspace:
-          at: ~/
-      - run: npm test
-  test-node9:
-    docker:
-      - image: circleci/node:9
-    steps:
-      - attach_workspace:
-          at: ~/
-      - run: npm test
   test-node10:
     docker:
       - image: circleci/node:10
@@ -55,7 +41,7 @@ jobs:
       - run: npm test
   publish-beta:
     docker:
-      - image: circleci/node:10
+      - image: circleci/node:12
     steps:
       - attach_workspace:
           at: ~/
@@ -67,7 +53,7 @@ jobs:
           command: npm publish --tag beta
   publish-stable:
     docker:
-      - image: circleci/node:10
+      - image: circleci/node:12
     steps:
       - attach_workspace:
           at: ~/
@@ -86,18 +72,6 @@ workflows:
           filters:
             tags:
               only: /.*/
-      - test-node8:
-          requires:
-            - build
-          filters:
-            tags:
-              only: /.*/
-      - test-node9:
-          requires:
-            - build
-          filters:
-            tags:
-              only: /.*/
       - test-node10:
           requires:
             - build
@@ -124,8 +98,6 @@ workflows:
               only: /.*/
       - publish-beta:
           requires:
-            - test-node8
-            - test-node9
             - test-node10
             - test-node11
             - test-node12
@@ -138,8 +110,6 @@ workflows:
       - hold:
           type: approval
           requires:
-            - test-node8
-            - test-node9
             - test-node10
             - test-node11
             - test-node12

.npmpackagejsonlintrc.json

@@ -1,3 +1,6 @@
 {
-  "extends": "npm-package-json-lint-config-tc"
+  "extends": "npm-package-json-lint-config-tc",
+  "rules": {
+    "valid-values-engines": "off"
+  }
 }

README.md

@@ -22,7 +22,7 @@ First thing first, let's make sure you have the necessary pre-requisites.
 
 #### Node
 
-* [Node.js](https://nodejs.org/) - v8.0.0+
+* [Node.js](https://nodejs.org/) - v10.0.0+
 * [npm](http://npmjs.com) - v6.0.0+
 
 ### Command

index.js

@@ -87,6 +87,7 @@ module.exports = {
         'max-statements': 'off',
         'newline-after-var': 'off',
         'no-process-env': 'off',
+        'no-undefined': 'off',
         'no-unused-expressions': 'off',
         'no-unused-vars': 'off',
         'object-curly-newline': 'off',

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-tc",
-  "version": "10.0.1",
+  "version": "11.0.0",
   "description": "ESLint shareable config for JavaScript projects",
   "keywords": [
     "eslintconfig",
@@ -58,7 +58,7 @@
     "prettier": "^1.0.0"
   },
   "engines": {
-    "node": ">=8.0.0",
+    "node": ">=10.0.0",
     "npm": ">=6.0.0"
   },
   "license": "MIT"

rules/best-practices.js

@@ -2,6 +2,8 @@ module.exports = {
   rules: {
     'accessor-pairs': 'error',
     complexity: 'error',
+    'grouped-accessor-pairs': 'error',
+    'no-constructor-return': 'error',
     'no-div-regex': 'error',
     'no-empty-function': 'error',
     'no-eq-null': 'error',

rules/errors.js

@@ -2,6 +2,7 @@ module.exports = {
   rules: {
     'no-constant-condition': 'error',
     'no-prototype-builtins': 'error',
+    'no-setter-return': 'error',
     'require-atomic-updates': 'error'
   }
 };

rules/style.js

@@ -40,6 +40,7 @@ module.exports = {
       {blankLine: 'any', prev: 'cjs-import', next: '*'},
       {blankLine: 'any', prev: 'cjs-import', next: 'cjs-import'}
     ],
+    'prefer-exponentiation-operator': 'error',
     'sort-vars': 'error',
     'spaced-comment': ['error', 'always']
   }