refactor forms #1964
Open
refactor forms #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenhand
reviewed
Dec 28, 2023
Collaborator
stephenhand
left a comment
stephenhand
left a comment
There was a problem hiding this comment.
Can we leave the unit tests in _tests ? I don't want to be in a situation where some tests are under there and some tests are in the same folder as the code.
If we want to do the lift of moving all the existing tests up front that's one thing, but doing it piecemeal just seems like we'll be in a worse, inconsistent situation forever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary reviewer:
Description
Checklist
Related Issues
Fixes #....
Verification steps