Update CI jobs to correctly use npm cache

Also remove `setup-node` usage from the build test job as it only
needs go.

Author: AlanGreene

.github/workflows/ci.yml

@@ -42,14 +42,6 @@ jobs:
           cache-dependency-path: "${{ github.workspace }}/src/github.com/tektoncd/dashboard/go.sum"
           go-version-file: "${{ github.workspace }}/src/github.com/tektoncd/dashboard/go.mod"
 
-      - name: Set up Node.js
-        uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
-        with:
-          cache: npm
-          cache-dependency-path: src/github.com/tektoncd/dashboard/package-lock.json
-          node-version-file: src/github.com/tektoncd/dashboard/.nvmrc
-          registry-url: 'https://registry.npmjs.org/'
-
       - name: Install dependencies
         run: |
           echo "${GOPATH}/bin" >> "$GITHUB_PATH"

test/presubmit-tests.sh

@@ -83,10 +83,17 @@ function get_node() {
 function node_npm_install() {
   local failed=0
   get_node
-  echo "Configuring npm"
-  mkdir ~/.npm-global
-  npm config set prefix '~/.npm-global'
-  export PATH=$PATH:$HOME/.npm-global/bin
+  # echo "Configuring npm"
+  # set -x
+  # mkdir ~/.npm-global
+  # echo "Get npm cache location"
+  # npm config get cache
+  # echo "Set npm prefix"
+  # npm config set prefix '~/.npm-global'
+  # echo "Get npm cache location"
+  # npm config get cache
+  # export PATH=$PATH:$HOME/.npm-global/bin
+  # set +x
   echo "Installing package dependencies"
   npm ci || failed=1 # similar to `npm install` but ensures all versions from lock file
   return ${failed}