Skip to content

Commit c702741

Browse files
Conchylicultorcopybara-github
authored andcommitted
Fix backward compatibility breakage for interleave_cycle_length
PiperOrigin-RevId: 309021159
1 parent 9ba5872 commit c702741

File tree

1 file changed

+23
-10
lines changed

1 file changed

+23
-10
lines changed

tensorflow_datasets/core/utils/read_config.py

Lines changed: 23 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,14 @@
2727
import tensorflow.compat.v2 as tf
2828

2929

30+
_OLD = 'interleave_parallel_reads'
31+
_NEW = 'interleave_cycle_length'
32+
_WARNING_MSG = (
33+
'`{}` argument of `tfds.ReadConfig` is '
34+
'deprecated and will be removed in a future version. Please use '
35+
'`{}` instead.').format(_OLD, _NEW)
36+
37+
3038
# TODO(tfds): Use dataclasses once Py2 support is dropped
3139
@attr.s
3240
class _ReadConfig(object):
@@ -45,6 +53,16 @@ class _ReadConfig(object):
4553
interleave_block_length = attr.ib(default=16)
4654
experimental_interleave_sort_fn = attr.ib(default=None)
4755

56+
@property
57+
def interleave_parallel_reads(self):
58+
logging.warning(_WARNING_MSG)
59+
return self.interleave_cycle_length
60+
61+
@interleave_parallel_reads.setter
62+
def interleave_parallel_reads(self, value):
63+
logging.warning(_WARNING_MSG)
64+
self.interleave_cycle_length = value
65+
4866

4967
class ReadConfig(_ReadConfig):
5068
"""Configures input reading pipeline.
@@ -74,14 +92,9 @@ class ReadConfig(_ReadConfig):
7492
"""
7593

7694
def __init__(self, **kwargs):
77-
old = 'interleave_parallel_reads'
78-
new = 'interleave_cycle_length'
79-
if old in kwargs:
80-
if new in kwargs:
81-
raise ValueError('Cannot set both {} and {}'.format(old, new))
82-
logging.warning(
83-
'`%s` argument of `tfds.ReadConfig` is '
84-
'deprecated and will be removed in a future version. Please use '
85-
'`%s` instead.', old, new)
86-
kwargs[old] = kwargs.pop(new)
95+
if _OLD in kwargs:
96+
if _NEW in kwargs:
97+
raise ValueError('Cannot set both {} and {}'.format(_OLD, _NEW))
98+
logging.warning(_WARNING_MSG)
99+
kwargs[_OLD] = kwargs.pop(_NEW)
87100
super(ReadConfig, self).__init__(**kwargs)

0 commit comments

Comments
 (0)