Support transit_encryption_enabled for Redis Engine

[cmanzur]

Is your request related to a problem? Please describe.

Sorry if this an obvious question, but I don't understand why there's no option to enable in-transit encryption suing Redis:

Enginetransit_encryption_enabled = var.engine == "memcached" ? var.transit_encryption_enabled : null

https://github.com/terraform-aws-modules/terraform-aws-elasticache/blob/master/main.tf#L55C10-L56C8

Describe the solution you'd like.

The var.engine == "memcached" can also be redis

Additional context

https://docs.aws.amazon.com/AmazonElastiCache/latest/dg/in-transit-encryption.html#in-transit-encryption-constraints

[bryantbiggs]

because thats all that was supported at the time when it was implemented hashicorp/terraform-provider-aws@066e8f2

[cmanzur]

Should I open a PR to add this validation?

[bryantbiggs]

I would accept a PR to remove the var.engine == "memcached" logic seeing that its no longer required due to the upstream service support

[cmanzur]

@bryantbiggs I opened a PR here: #56

I don't know how to link the PR with this issue/feature

[cmanzur]

Just a little note:
In my local environment using terraform 1.12.2 and pre-commit 4.2.0 if I run pre-commit run -a

Terraform wrapper with for_each in module................................Failed
- hook id: terraform_wrapper_module_for_each
- files were modified by this hook

Then, it automatically switched the lines 10 and 11 in wrappers/main.tf

That' why this Github Action Failed.

I rollback that change, but just to let you know something is different here in the CICD than in my machine

[antonbabenko]

This issue has been resolved in version 1.10.1 🎉