fix: archive-type validation error (#41)

* fix: archive-type validation error

* fix reference to architecture diagram

Author: chrisw-ibm

README.md

@@ -47,7 +47,7 @@ https://terraform-ibm-modules.github.io/documentation/#/implementation-guideline
 -->
 ## Reference architectures
 
-![cloudability-all-inclusive-onboarding](./reference-architecture/cloudability-all-inclusive-onboarding.svg)
+![cloudability-all-inclusive-onboarding](./reference-architectures/cloudability-all-inclusive-onboarding.svg)
 
 <!-- This heading should always match the name of the root level module (aka the repo name) -->
 ## terraform-ibm-cloudability-onboarding
@@ -127,7 +127,7 @@ statement instead the previous block.
 | <a name="input_activity_tracker_read_data_events"></a> [activity\_tracker\_read\_data\_events](#input\_activity\_tracker\_read\_data\_events) | If set to true, all Object Storage bucket read events (i.e. downloads) will be sent to Activity Tracker. | `bool` | `true` | no |
 | <a name="input_activity_tracker_write_data_events"></a> [activity\_tracker\_write\_data\_events](#input\_activity\_tracker\_write\_data\_events) | If set to true, all Object Storage bucket read events (i.e. downloads) will be sent to Activity Tracker. | `bool` | `true` | no |
 | <a name="input_add_bucket_name_suffix"></a> [add\_bucket\_name\_suffix](#input\_add\_bucket\_name\_suffix) | Add random generated suffix (4 characters long) to the newly provisioned Object Storage bucket name (Optional). | `bool` | `true` | no |
-| <a name="input_archive_days"></a> [archive\_days](#input\_archive\_days) | Specifies the number of days when the archive rule action takes effect. This must be set to null when when using var.cross\_region\_location as archive data is not supported with this feature. | `number` | `null` | no |
+| <a name="input_archive_days"></a> [archive\_days](#input\_archive\_days) | Specifies the number of days when the archive rule action takes effect. A value of `null` disables archiving. A value of `0` immediately archives uploaded objects to the bucket. | `number` | `null` | no |
 | <a name="input_archive_type"></a> [archive\_type](#input\_archive\_type) | Specifies the storage class or archive type to which you want the object to transition. | `string` | `"Glacier"` | no |
 | <a name="input_bucket_cbr_rules"></a> [bucket\_cbr\_rules](#input\_bucket\_cbr\_rules) | (Optional, list) List of CBR rules to create for the bucket | <pre>list(object({<br/>    description = string<br/>    account_id  = string<br/>    rule_contexts = list(object({<br/>      attributes = optional(list(object({<br/>        name  = string<br/>        value = string<br/>    }))) }))<br/>    enforcement_mode = string<br/>    tags = optional(list(object({<br/>      name  = string<br/>      value = string<br/>    })), [])<br/>    operations = optional(list(object({<br/>      api_types = list(object({<br/>        api_type_id = string<br/>      }))<br/>    })))<br/>  }))</pre> | `[]` | no |
 | <a name="input_bucket_name"></a> [bucket\_name](#input\_bucket\_name) | The name to give the newly provisioned Object Storage bucket. | `string` | `"apptio-cldy-billing-snapshots"` | no |

ibm_catalog.json

@@ -99,7 +99,7 @@
 								"diagram": {
 									"caption": "All inclusive Cloudability Onboarding",
 									"type": "image/svg+xml",
-									"url": "https://raw.githubusercontent.com/terraform-ibm-modules/terraform-ibm-cloudability-onboarding/refs/heads/main/reference-architecture/cloudability-all-inclusive-onboarding.svg"
+									"url": "https://raw.githubusercontent.com/terraform-ibm-modules/terraform-ibm-cloudability-onboarding/refs/heads/main/reference-architectures/cloudability-all-inclusive-onboarding.svg"
 								},
 								"description": "Billing reports are written to a Key Protect encrypted object storage bucket. IBM Cloudability is granted access to read from this bucket. Your IBM Cloud account is added to Cloudability so that it knows how to read the data from the object storage bucket."
 							}
@@ -372,23 +372,23 @@
 							"key": "archive_days",
 							"type": "number",
 							"default_value": "__NULL__",
-							"description": "Specifies the number of days when the archive rule action takes effect.",
+							"description": "Specifies the number of days when the archive rule action takes effect. A value of `__NULL__` disables archiving. A value of `0` immediately archives uploaded objects to the bucket.",
 							"required": false
 						},
 						{
 							"key": "archive_type",
 							"type": "string",
-							"default_value": "GLACIER",
+							"default_value": "Glacier",
 							"description": "Specifies the storage class or archive type to which you want the object to transition.",
 							"required": false,
 							"options": [
 								{
-									"displayname": "Glacier",
-									"value": "GLACIER"
+									"displayname": "Archive (restore in < 12 hours)",
+									"value": "Glacier"
 								},
 								{
-									"displayname": "Accelerated",
-									"value": "ACCELERATED"
+									"displayname": "Accelerated Archive (restore in < 2 hours)",
+									"value": "Accelerated"
 								}
 							]
 						},

variables.tf

@@ -234,7 +234,7 @@ variable "object_versioning_enabled" {
 }
 
 variable "archive_days" {
-  description = "Specifies the number of days when the archive rule action takes effect. This must be set to null when when using var.cross_region_location as archive data is not supported with this feature."
+  description = "Specifies the number of days when the archive rule action takes effect. A value of `null` disables archiving. A value of `0` immediately archives uploaded objects to the bucket."
   type        = number
   default     = null
 }