Skip to content

Commit ff423e7

Browse files
fix(deps): update terraform-module (#23)
* fix(deps): update terraform-module * remove activity_tracker_crn since activity tracker is deprecated. see terraform-ibm-modules/terraform-ibm-cos#738 --------- Co-authored-by: Chris Waddington <104161708+chrisw-ibm@users.noreply.github.com>
1 parent f48ce16 commit ff423e7

File tree

7 files changed

+9
-36
lines changed

7 files changed

+9
-36
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,7 @@ statement instead the previous block.
121121
| Name | Description | Type | Default | Required |
122122
|------|-------------|------|---------|:--------:|
123123
| <a name="input_access_tags"></a> [access\_tags](#input\_access\_tags) | A list of access tags to apply to the cos instance created by the module, see https://cloud.ibm.com/docs/account?topic=account-access-tags-tutorial for more details | `list(string)` | `[]` | no |
124-
| <a name="input_activity_tracker_crn"></a> [activity\_tracker\_crn](#input\_activity\_tracker\_crn) | The CRN of an Activity Tracker instance to send Object Storage bucket events to. If no value passed, events are sent to the instance associated to the container's location unless otherwise specified in the Activity Tracker Event Routing service configuration. | `string` | `null` | no |
125-
| <a name="input_activity_tracker_management_events"></a> [activity\_tracker\_management\_events](#input\_activity\_tracker\_management\_events) | If set to true, all Object Storage management events will be sent to Activity Tracker. Only applies if `activity_tracker_crn` is not populated. | `bool` | `true` | no |
124+
| <a name="input_activity_tracker_management_events"></a> [activity\_tracker\_management\_events](#input\_activity\_tracker\_management\_events) | If set to true, all Object Storage management events will be sent to Activity Tracker. | `bool` | `true` | no |
126125
| <a name="input_activity_tracker_read_data_events"></a> [activity\_tracker\_read\_data\_events](#input\_activity\_tracker\_read\_data\_events) | If set to true, all Object Storage bucket read events (i.e. downloads) will be sent to Activity Tracker. | `bool` | `true` | no |
127126
| <a name="input_activity_tracker_write_data_events"></a> [activity\_tracker\_write\_data\_events](#input\_activity\_tracker\_write\_data\_events) | If set to true, all Object Storage bucket write events (i.e. uploads) will be sent to Activity Tracker. | `bool` | `true` | no |
128127
| <a name="input_add_bucket_name_suffix"></a> [add\_bucket\_name\_suffix](#input\_add\_bucket\_name\_suffix) | Add random generated suffix (4 characters long) to the newly provisioned COS bucket name (Optional). | `bool` | `true` | no |

ibm_catalog.json

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -244,13 +244,6 @@
244244
"description": "The name of a new or existing resource group where resources will be created",
245245
"required": false
246246
},
247-
{
248-
"key": "activity_tracker_crn",
249-
"type": "string",
250-
"default_value": "__NULL__",
251-
"description": "The CRN of an Activity Tracker instance to send Object Storage bucket events to. If no value passed, events are sent to the instance associated to the container's location unless otherwise specified in the Activity Tracker Event Routing service configuration.",
252-
"required": false
253-
},
254247
{
255248
"key": "activity_tracker_read_data_events",
256249
"type": "boolean",
@@ -269,7 +262,7 @@
269262
"key": "activity_tracker_management_events",
270263
"type": "boolean",
271264
"default_value": "true",
272-
"description": "If set to true, all Object Storage management events will be sent to Activity Tracker. Only applies if `activity_tracker_crn` is not populated.",
265+
"description": "If set to true, all Object Storage management events will be sent to Activity Tracker.",
273266
"required": false
274267
},
275268
{

main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ module "cos_bucket" {
5858
archive_days = var.archive_days
5959
archive_type = var.archive_type
6060
expire_days = var.expire_days
61-
activity_tracker_crn = var.activity_tracker_crn
6261
activity_tracker_read_data_events = var.activity_tracker_read_data_events
6362
activity_tracker_write_data_events = var.activity_tracker_write_data_events
6463
activity_tracker_management_events = var.activity_tracker_management_events

modules/encrypted_cos_bucket/README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ statement instead the previous block.
7171

7272
| Name | Source | Version |
7373
|------|--------|---------|
74-
| <a name="module_cos_bucket"></a> [cos\_bucket](#module\_cos\_bucket) | terraform-ibm-modules/cos/ibm | 8.11.14 |
75-
| <a name="module_key_protect_all_inclusive"></a> [key\_protect\_all\_inclusive](#module\_key\_protect\_all\_inclusive) | terraform-ibm-modules/kms-all-inclusive/ibm | 4.15.13 |
74+
| <a name="module_cos_bucket"></a> [cos\_bucket](#module\_cos\_bucket) | terraform-ibm-modules/cos/ibm | 8.13.2 |
75+
| <a name="module_key_protect_all_inclusive"></a> [key\_protect\_all\_inclusive](#module\_key\_protect\_all\_inclusive) | terraform-ibm-modules/kms-all-inclusive/ibm | 4.16.4 |
7676

7777
### Resources
7878

@@ -83,8 +83,7 @@ No resources.
8383
| Name | Description | Type | Default | Required |
8484
|------|-------------|------|---------|:--------:|
8585
| <a name="input_access_tags"></a> [access\_tags](#input\_access\_tags) | A list of access tags to apply to the cos instance created by the module, see https://cloud.ibm.com/docs/account?topic=account-access-tags-tutorial for more details | `list(string)` | `[]` | no |
86-
| <a name="input_activity_tracker_crn"></a> [activity\_tracker\_crn](#input\_activity\_tracker\_crn) | The CRN of an Activity Tracker instance to send Object Storage bucket events to. If no value passed, events are sent to the instance associated to the container's location unless otherwise specified in the Activity Tracker Event Routing service configuration. Bucket management events are always enabled if a value is passed, regardless of the value of `activity_tracker_management_events`. | `string` | `null` | no |
87-
| <a name="input_activity_tracker_management_events"></a> [activity\_tracker\_management\_events](#input\_activity\_tracker\_management\_events) | If set to true, all Object Storage management events will be sent to Activity Tracker. Only applies if `activity_tracker_crn` is not populated. | `bool` | `true` | no |
86+
| <a name="input_activity_tracker_management_events"></a> [activity\_tracker\_management\_events](#input\_activity\_tracker\_management\_events) | If set to true, all Object Storage management events will be sent to Activity Tracker. | `bool` | `true` | no |
8887
| <a name="input_activity_tracker_read_data_events"></a> [activity\_tracker\_read\_data\_events](#input\_activity\_tracker\_read\_data\_events) | If set to true, all Object Storage bucket read events (i.e. downloads) will be sent to Activity Tracker. | `bool` | `true` | no |
8988
| <a name="input_activity_tracker_write_data_events"></a> [activity\_tracker\_write\_data\_events](#input\_activity\_tracker\_write\_data\_events) | If set to true, all Object Storage bucket write events (i.e. uploads) will be sent to Activity Tracker. | `bool` | `true` | no |
9089
| <a name="input_add_bucket_name_suffix"></a> [add\_bucket\_name\_suffix](#input\_add\_bucket\_name\_suffix) | Add random generated suffix (4 characters long) to the newly provisioned COS bucket name (Optional). | `bool` | `false` | no |

modules/encrypted_cos_bucket/main.tf

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ module "key_protect_all_inclusive" {
2222
}
2323
count = var.create_key_protect_instance ? 1 : 0
2424
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
25-
version = "4.15.13"
25+
version = "4.16.4"
2626
key_protect_instance_name = var.key_protect_instance_name
2727
resource_group_id = var.resource_group_id
2828
enable_metrics = true
@@ -60,7 +60,7 @@ module "cos_bucket" {
6060
ibm = ibm
6161
}
6262
source = "terraform-ibm-modules/cos/ibm"
63-
version = "8.11.14"
63+
version = "8.13.2"
6464
bucket_name = var.bucket_name
6565
add_bucket_name_suffix = var.add_bucket_name_suffix
6666
management_endpoint_type_for_bucket = var.management_endpoint_type_for_bucket
@@ -75,7 +75,6 @@ module "cos_bucket" {
7575
archive_days = var.archive_days
7676
archive_type = var.archive_type
7777
monitoring_crn = var.monitoring_crn
78-
activity_tracker_crn = var.activity_tracker_crn
7978
activity_tracker_read_data_events = var.activity_tracker_read_data_events
8079
activity_tracker_write_data_events = var.activity_tracker_write_data_events
8180
activity_tracker_management_events = var.activity_tracker_management_events

modules/encrypted_cos_bucket/variables.tf

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -219,12 +219,6 @@ variable "expire_days" {
219219
default = null
220220
}
221221

222-
variable "activity_tracker_crn" {
223-
type = string
224-
description = "The CRN of an Activity Tracker instance to send Object Storage bucket events to. If no value passed, events are sent to the instance associated to the container's location unless otherwise specified in the Activity Tracker Event Routing service configuration. Bucket management events are always enabled if a value is passed, regardless of the value of `activity_tracker_management_events`."
225-
default = null
226-
}
227-
228222
variable "activity_tracker_read_data_events" {
229223
type = bool
230224
description = "If set to true, all Object Storage bucket read events (i.e. downloads) will be sent to Activity Tracker."
@@ -239,7 +233,7 @@ variable "activity_tracker_write_data_events" {
239233

240234
variable "activity_tracker_management_events" {
241235
type = bool
242-
description = "If set to true, all Object Storage management events will be sent to Activity Tracker. Only applies if `activity_tracker_crn` is not populated."
236+
description = "If set to true, all Object Storage management events will be sent to Activity Tracker."
243237
default = true
244238
}
245239

variables.tf

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -303,16 +303,6 @@ variable "expire_days" {
303303
default = null
304304
}
305305

306-
variable "activity_tracker_crn" {
307-
type = string
308-
description = "The CRN of an Activity Tracker instance to send Object Storage bucket events to. If no value passed, events are sent to the instance associated to the container's location unless otherwise specified in the Activity Tracker Event Routing service configuration."
309-
default = null
310-
validation {
311-
condition = var.activity_tracker_crn != null ? can(regex("crn:v1:bluemix:public:logdnaat:(in-che|jp-tok|jp-osa|ca-tor|br-sao|au-syd|eu-gb|eu-es|us-south|eu-de|us-east):a/[0-9a-f]{32}:[0-9a-fA-F]{8}-([0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}::", var.activity_tracker_crn)) : true
312-
error_message = "Must be a valid activity tracker crn"
313-
}
314-
}
315-
316306
variable "activity_tracker_read_data_events" {
317307
type = bool
318308
description = "If set to true, all Object Storage bucket read events (i.e. downloads) will be sent to Activity Tracker."
@@ -327,7 +317,7 @@ variable "activity_tracker_write_data_events" {
327317

328318
variable "activity_tracker_management_events" {
329319
type = bool
330-
description = "If set to true, all Object Storage management events will be sent to Activity Tracker. Only applies if `activity_tracker_crn` is not populated."
320+
description = "If set to true, all Object Storage management events will be sent to Activity Tracker."
331321
default = true
332322
}
333323

0 commit comments

Comments
 (0)