feat: added the new worker_node_flavors widget #88
+25
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
…-ocp-ai into 16403-new-widget
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
1 similar comment
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Comment on lines
+624
to
+635
| "required": true, | ||
| "custom_config": { | ||
| "type": "worker_node_flavors", | ||
| "grouping": "deployment", | ||
| "original_grouping": "deployment", | ||
| "associations": { | ||
| "parameters": [ | ||
| { | ||
| "name": "region", | ||
| "optionsRefresh": true | ||
| } | ||
| ] |
Member
There was a problem hiding this comment.
do we need this here as its a quickstart? Is it not hidden in qs?
@imprateeksh what do you suggest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change includes the new worker node flavors(machine type) widget which was added as an enhancement. The default_worker_pool_machine_type parameter in the IBM Cloud catalog configuration now uses a dynamic worker_node_flavors widget instead of a static dropdown list.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
The widget now dynamically fetches available worker node flavors based on the selected region, ensuring users only see machine types that are actually available in their chosen deployment location. With optionsRefresh: true, the machine type options automatically update when the user changes the region selection, providing real-time accuracy. These changes highlight the significant UX improvement this widget brings to the catalog experience!
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers