Skip to content
This repository was archived by the owner on Jun 29, 2023. It is now read-only.
This repository was archived by the owner on Jun 29, 2023. It is now read-only.

Unnecessary restriction on MassMigration commitments #683

@msieczko

Description

@msieczko

The current implementation of claimTokens method blacklists a pubkeyID for given withdrawRoot to prevent claiming the same token amount twice.

require(
!Bitmap.isClaimed(withdrawal.state.pubkeyID, bitmap[withdrawRoot]),
"WithdrawManager: Token has been claimed"
);

As a result this introduces a restriction on the MassMigration transactions that can be put into a single commitment. Namely, there can be no two transactions from UserStates with the same pubkeyID in a single MassMigration commitment.

Instead we could blacklist a specific path in withdraw states tree to drop this unnecessary restriction.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions