Skip to content

Commit 54674d5

Browse files
authored
Merge pull request #1349 from Sephster/fix-php-8-test-runner
Fix PHP 8 Test Runner
2 parents 591a631 + a10cde3 commit 54674d5

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

.github/workflows/tests.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,21 @@ on:
88

99
jobs:
1010
tests:
11-
runs-on: ubuntu-latest
12-
1311
strategy:
1412
fail-fast: false
1513
matrix:
16-
php: [8.0, 8.1, 8.2]
14+
php: [8.1, 8.2]
15+
os: [ubuntu-22.04]
1716
stability: [prefer-lowest, prefer-stable]
17+
include:
18+
- os: ubuntu-20.04
19+
php: 8.0
20+
stability: prefer-lowest
21+
- os: ubuntu-20.04
22+
php: 8.0
23+
stability: prefer-stable
24+
25+
runs-on: ${{ matrix.os }}
1826

1927
name: PHP ${{ matrix.php }} - ${{ matrix.stability }}
2028

tests/Utils/CryptKeyTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ public function testKeyString()
5454

5555
public function testUnsupportedKeyType()
5656
{
57-
if (\str_starts_with(\phpversion(), '8.0')) {
58-
$this->markTestSkipped('Cannot generate key on PHP 8.0 runner. Investigating');
59-
}
6057
$this->expectException(\LogicException::class);
6158
$this->expectExceptionMessage('Unable to read key');
6259

0 commit comments

Comments
 (0)