You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for your job! This Lua module is very useful.
I'm trying to cooperate this Lua module with lua-resty-redis, so that we can communicate with our Redis servers in these "non-yield" phases.
I find the internal function flatten doesn't handle the number type. In lua-resty-redis, parameters passed to sock:send might be a Lua table with kinds of data type like string, number. Even in the implementations of luasocket, it uses luaL_checklstring, which also can convert number to string.
So maybe we should consider the number type. What's your opinion?
The text was updated successfully, but these errors were encountered:
tokers
changed the title
flatten data with tostring
consider number type in the flatten function
Feb 13, 2019
Hi, Thibault!
Thanks for your job! This Lua module is very useful.
I'm trying to cooperate this Lua module with lua-resty-redis, so that we can communicate with our Redis servers in these "non-yield" phases.
I find the internal function
flatten
doesn't handle the number type. In lua-resty-redis, parameters passed to sock:send might be a Lua table with kinds of data type like string, number. Even in the implementations of luasocket, it usesluaL_checklstring
, which also can convert number to string.So maybe we should consider the number type. What's your opinion?
The text was updated successfully, but these errors were encountered: